Closed
Bug 1320697
Opened 8 years ago
Closed 8 years ago
Wrong assertion in jsscript.cpp: MOZ_ASSERT(!srcFun->isAsync());
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | unaffected |
firefox50 | --- | unaffected |
firefox51 | --- | unaffected |
firefox52 | --- | fixed |
firefox53 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(2 files)
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
arai
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
CloneInnerInterpretedFunction is called on unwrapped function, that is just a generator at that point, and it can be cloned without any issue.
also, we need to clone unwrapped function if it appears in XUL.
So, the assertion just need to be removed.
Assignee | ||
Comment 1•8 years ago
|
||
Just removed the wrong assertion in CloneInnerInterpretedFunction,
and added testcase for cloneAndExecuteScript.
Comment 2•8 years ago
|
||
Comment on attachment 8814937 [details] [diff] [review]
Remove wrong assertion in jsscript.cpp.
Review of attachment 8814937 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense.
Attachment #8814937 -
Flags: review?(till) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Thank you for reviewing :D
status-firefox50:
--- → unaffected
status-firefox51:
--- → unaffected
status-firefox52:
--- → affected
status-firefox-esr45:
--- → unaffected
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b68b4d00610f0628cb5fac27600670815100f42
Bug 1320697 - Remove wrong assertion in jsscript.cpp. r=till
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 6•8 years ago
|
||
Approval Request Comment
> [Feature/Bug causing the regression]
bug 1185106
> [User impact if declined]
no user impact
automated test with debug build may hit this wrong assertion when a patch that uses async function is backported to the branch
> [Is this code covered by automated tests?]
yes
> [Has the fix been verified in Nightly?]
yes
> [Needs manual test from QE? If yes, steps to reproduce]
no
> [List of other uplifts needed for the feature/fix]
none
> [Is the change risky?]
no
> [Why is the change risky/not risky?]
just removed wrong assertion and has no effect on non-debug build
> [String changes made/needed]
none
Attachment #8815651 -
Flags: review+
Attachment #8815651 -
Flags: approval-mozilla-aurora?
Comment 7•8 years ago
|
||
Comment on attachment 8815651 [details] [diff] [review]
(mozilla-aurora) Remove wrong assertion in jsscript.cpp. r=till
remove wrong assert for debug builds, aurora52+
Attachment #8815651 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder uplift |
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•