Closed
Bug 1320709
Opened 8 years ago
Closed 8 years ago
selectForOfflineUse button completely fails to show the icon due to fallout from bug 348720
Categories
(SeaMonkey :: Themes, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.50
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
(Keywords: classic)
Attachments
(1 file)
|
(deleted),
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
(neil@parkwaycc.co.uk from Bug 1160716 comment #10)
> Making this style important should fix this bug, at the expense of the
> selectForOfflineUse button which has a 4px margin for some reason. (It also
> completely fails to show the icon due to fallout from bug 348720...)
|
Assignee | |
Comment 1•8 years ago
|
||
Affects classic theme in OSX as well so r?Stefan
Attachment #8814980 -
Flags: review?(stefanh)
Attachment #8814980 -
Flags: review?(iann_bugzilla)
|
||
Comment 2•8 years ago
|
||
I would actuall prefer not having that icon there since you really don't put icons in push buttons on Mac :-)
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8814980 [details] [diff] [review]
Patch to s/offline.gif/offline.png/
># HG changeset patch
># User Philip Chee <philip.chee@gmail.com>
># Parent 98b0ad0191f950efb38722735949a7e334a84c85
>Bug 1320709 - buttons with selectForOfflineUse class are missing the icon because offline.gif is now offline.png.
>(fallout from bug 348720)
>
>diff --git a/suite/themes/classic/mac/messenger/accountManage.css b/suite/themes/classic/mac/messenger/accountManage.css
>--- a/suite/themes/classic/mac/messenger/accountManage.css
>+++ b/suite/themes/classic/mac/messenger/accountManage.css
.
.
.
> .selectForOfflineUseButton {
>- list-style-image: url("chrome://communicator/skin/icons/offline.gif");
>+ list-style-image: url("chrome://communicator/skin/icons/offline.png");
> }
>
> .selectForOfflineUseButton > .button-box > .button-icon {
> margin-inline-start: 4px;
> margin-inline-end: 4px;
> }
>
Thanks for noticing this. You can actually remove all the above style rules, it looks odd with an icon in a Mac pushbutton. r=me for everything with that fixed :-)
Attachment #8814980 -
Flags: review?(stefanh)
Attachment #8814980 -
Flags: review?(iann_bugzilla)
Attachment #8814980 -
Flags: review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
>> .selectForOfflineUseButton {
>>- list-style-image: url("chrome://communicator/skin/icons/offline.gif");
>>+ list-style-image: url("chrome://communicator/skin/icons/offline.png");
>> }
>>
>> .selectForOfflineUseButton > .button-box > .button-icon {
>> margin-inline-start: 4px;
>> margin-inline-end: 4px;
>> }
>>
> Thanks for noticing this. You can actually remove all the above style rules,
> it looks odd with an icon in a Mac pushbutton. r=me for everything with that
> fixed :-)
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/f86d97d3aee0
Changeset: f86d97d3aee08f99af8afb6fd47357dfe3c711c0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.50
You need to log in
before you can comment on or make changes to this bug.
Description
•