Closed Bug 1320809 Opened 8 years ago Closed 8 years ago

Remove the unused IsChecked() and IsIndeterminate() methods from nsGfxCheckboxControlFrame

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- disabled
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Remove the unused IsChecked() and IsIndeterminate() methods from nsGfxCheckboxControlFrame
(deleted), patch
dholbert
: review+
Details | Diff | Splinter Review
Like the summary says....
Comment on attachment 8815091 [details] [diff] [review] Remove the unused IsChecked() and IsIndeterminate() methods from nsGfxCheckboxControlFrame Review of attachment 8815091 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Death to dead code. r=me
Attachment #8815091 - Flags: review?(dholbert) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6114d21c87ca Remove the unused IsChecked() and IsIndeterminate() methods from nsGfxCheckboxControlFrame. r=dholbert
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b55a8d9517c8 Remove the unused IsChecked() and IsIndeterminate() methods from nsGfxCheckboxControlFrame. r=dholbert
That unexpected pass had nothing to do with this dead code removal. Relanded.
Flags: needinfo?(bzbarsky)
https://hg.mozilla.org/mozilla-central/rev/b55a8d9517c8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: