Closed
Bug 1321233
(SQLite3.15.2)
Opened 8 years ago
Closed 8 years ago
Upgrade to SQLite 3.15.2
Categories
(Toolkit :: Storage, defect)
Toolkit
Storage
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: ionnv, Assigned: RyanVM)
References
()
Details
Attachments
(1 file)
(deleted),
patch
|
mak
:
review+
jcristau
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
https://sqlite.org/news.html
https://sqlite.org/releaselog/3_15_2.html
SQLite version 3.15.2 is a bug-fix patch release that fixes several minor issues in the 3.15.0 and 3.15.1 releases.
Depends on: SQLite3.15.1
Comment 1•8 years ago
|
||
Thanks, the fixes don't seem to affect us, but row values are handy and I think people will start using them soon. So regardless we should pick this, it should be pretty much a safe upgrade, it won't need an uplift.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•8 years ago
|
||
I'm inclined to uplift since 52 is an ESR and we've got lots of bake time anyway.
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8815715 -
Flags: review?(mak77)
Comment 4•8 years ago
|
||
Comment on attachment 8815715 [details] [diff] [review]
Upgrade SQLite to version 3.15.2
Review of attachment 8815715 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, considering the ESR it would make sense, there's nothing scary here.
Attachment #8815715 -
Flags: review?(mak77) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5f18d49b829
Upgrade to SQLite 3.15.2. r=mak
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: SQLite3.16.2
Comment 7•8 years ago
|
||
Ryan, is you want this in 52, please fill the uplift request asap.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8815715 [details] [diff] [review]
Upgrade SQLite to version 3.15.2
Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: possible crashes under some circumstances
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not really
[Why is the change risky/not risky?]: SQLite has a very good upstream test suite and we also have a lot of in-tree test coverage for features that depend on it.
[String changes made/needed]: none
Flags: needinfo?(ryanvm)
Attachment #8815715 -
Flags: approval-mozilla-beta?
Comment 9•8 years ago
|
||
Comment on attachment 8815715 [details] [diff] [review]
Upgrade SQLite to version 3.15.2
bump sqlite from 3.15.1 to 3.15.2, beta52+
Attachment #8815715 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 10•8 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•