Closed
Bug 1321274
Opened 8 years ago
Closed 8 years ago
Remove usage of javascript String generics
Categories
(MailNews Core :: Backend, defect)
Tracking
(thunderbird53 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| thunderbird53 | --- | fixed |
People
(Reporter: aryx, Assigned: aryx)
References
Details
Attachments
(3 files)
String generics are non-standard SpiderMonkey extension and they should be removed.
* String.charAt
* String.charCodeAt
* String.concat
* String.contains
* String.endsWith
* String.includes
* String.indexOf
* String.lastIndexOf
* String.localeCompare
* String.match
* String.normalize
* String.replace
* String.search
* String.slice
* String.split
* String.startsWith
* String.substr
* String.substring
* String.toLocaleLowerCase
* String.toLocaleUpperCase
* String.toLowerCase
* String.toUpperCase
* String.trim
* String.trimLeft
* String.trimRight
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8815780 [details]
Bug 1321274 - Remove usage of javascript String generics.
https://reviewboard.mozilla.org/r/96586/#review96796
Attachment #8815780 -
Flags: review?(philipp) → review+
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8815781 [details]
Bug 1321274 - Remove usage of javascript String generics: chat/im.
https://reviewboard.mozilla.org/r/96588/#review96804
Attachment #8815781 -
Flags: review?(aleth) → review+
|
Assignee | |
Updated•8 years ago
|
Attachment #8815782 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8815782 [details]
Bug 1321274 - Remove usage of javascript String generics: mail.
https://reviewboard.mozilla.org/r/96590/#review97260
LGTM! r=mkmmelin
Attachment #8815782 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
calendar: https://hg.mozilla.org/comm-central/rev/712ce63ce4be9b922a85af8f06fd81b4d30a8b8b
chat & im: https://hg.mozilla.org/comm-central/rev/14dc361515067ad74811e70543cc4acc7266e212
mail: https://hg.mozilla.org/comm-central/rev/fa53301f7178e84b38403e83dfaa7f71a28f357a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-thunderbird53:
--- → fixed
Resolution: --- → FIXED
Version: unspecified → 53
You need to log in
before you can comment on or make changes to this bug.
Description
•