Closed Bug 1321371 Opened 8 years ago Closed 8 years ago

single head per branch hook doesn't ignore hidden changesets

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

References

(Blocks 2 open bugs)

Details

Attachments

(3 files)

hghooks: refactor code to facilitate more complex conditionals;
(deleted), text/x-review-board-request
smacleod
: review+
Details
hghooks: add test for hidden heads (bug 1321371);
(deleted), text/x-review-board-request
smacleod
: review+
Details
hghooks: filter out hidden changesets (bug 1321371);
(deleted), text/x-review-board-request
smacleod
: review+
Details
The single head per branch hook apparently gives false positives when there are hidden changesets involved. This was found as part of doing history rewriting in bug 1321184.
This bit us again today. Enough is enough.
Assignee: nobody → gps
Status: NEW → ASSIGNED
QA Contact: hwine → klibby
Comment on attachment 8818729 [details] hghooks: refactor code to facilitate more complex conditionals; https://reviewboard.mozilla.org/r/98674/#review103654
Attachment #8818729 - Flags: review?(smacleod) → review+
Comment on attachment 8818730 [details] hghooks: add test for hidden heads (bug 1321371); https://reviewboard.mozilla.org/r/98676/#review103656
Attachment #8818730 - Flags: review?(smacleod) → review+
Comment on attachment 8818731 [details] hghooks: filter out hidden changesets (bug 1321371); https://reviewboard.mozilla.org/r/98678/#review103658
Attachment #8818731 - Flags: review?(smacleod) → review+
Pushed by smacleod@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/8e257192382b hghooks: add test for hidden heads ; r=smacleod https://hg.mozilla.org/hgcustom/version-control-tools/rev/d32600ce41c7 hghooks: filter out hidden changesets ; r=smacleod
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1365318
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: