[Tracking Requested - why for this release]: Unnecessary scrollbars appear on video document Reproducible: 100& Steps to reproduce: 1. Reduce browser size so that video will be resized to fit 2. Open video document Actual Results: Unnecessary scrollbars appear. See attached screenshot Expected Results: No scrollbar Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ec7fb4f14d3ec23ded7eea40ff49ebbcbec6bde1&tochange=8d2eecb7ea5a16e02862dd326ce4519082ce9901 Regressed by : Bug 1271765

Hi Alice The default box-sizing of elements is `content-box`, but after visual refresh, we added a 1px border around video element, then the actual width/height would be 2px larger than measured width/height properties. Changing box-sizing from `content-box` to `border-box` should fix this issue.

(In reply to Ray Lin[:ralin] from comment #5) > Hi Alice > > The default box-sizing of elements is `content-box`, but after visual > refresh, we added a 1px border around video element, then the actual > width/height would be 2px larger than measured width/height properties. > Changing box-sizing from `content-box` to `border-box` should fix this issue. Adding "box-sizing: border-box;" css property to the video, indeed, the scrollbars are disappear. However, the video size is 2px smaller than before. i.e, unnecessary black 1px border exists around the video. see attached screenshot.

I think we should remove that border as it takes unnecessary screen estate. Please work with visual designer to confirm that.

discussed with Peko offline, and she thought that there's no necessary to to keep the border either. A quick fix will be pushed in minutes.... :)

Tracking 53+ for this for all the reasons in the nomination comment.

Comment on attachment 8815972 [details] Bug 1321416 - remove border to get rid of scrollbar in top level synthetic video document. https://reviewboard.mozilla.org/r/96734/#review98726

Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1728d09549b remove border to get rid of scrollbar in top level synthetic video document. r=jaws

Backed out for failing test_videocontrols_standalone.html: https://hg.mozilla.org/integration/autoland/rev/19d673ccd8cdf25d3238808ba17ce05555afea61 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c1728d09549b2941287b823f6fda315bf5ef72a7 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=7881491&repo=autoland [task 2016-12-14T08:55:10.249069Z] 08:55:10 INFO - TEST-START | toolkit/content/tests/widgets/test_videocontrols_standalone.html [task 2016-12-14T08:55:42.683388Z] 08:55:42 INFO - TEST-INFO | started process screentopng [task 2016-12-14T08:55:44.437590Z] 08:55:44 INFO - TEST-INFO | screentopng: exit 0 [task 2016-12-14T08:55:44.446907Z] 08:55:44 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_videocontrols_standalone.html | The media element should eventually be resized to match the intrinsic size of the video. [task 2016-12-14T08:55:44.447270Z] 08:55:44 INFO - waitForCondition/interval<@toolkit/content/tests/widgets/head.js:7:7 [task 2016-12-14T08:55:44.448902Z] 08:55:44 INFO - setInterval handler*waitForCondition@toolkit/content/tests/widgets/head.js:5:18 [task 2016-12-14T08:55:44.450556Z] 08:55:44 INFO - runTestVideo@toolkit/content/tests/widgets/test_videocontrols_standalone.html:44:3 [task 2016-12-14T08:55:44.452187Z] 08:55:44 INFO - onLoad@toolkit/content/tests/widgets/test_videocontrols_standalone.html:29:5 [task 2016-12-14T08:55:44.453801Z] 08:55:44 INFO - EventListener.handleEvent*@toolkit/content/tests/widgets/test_videocontrols_standalone.html:25:1 [task 2016-12-14T08:55:44.456368Z] 08:55:44 INFO - Not taking screenshot here: see the one that was previously logged and more

Thank you :aryx my fault that forgot to adjust the dimension test after removed border. Updated a new patch now, and tested locally. ------ Sorry for asking for review again, as I push another mozreview that carry with a different rsa key or bugzilla API(I guess....) due to my laptop is unavailable now :(

Comment on attachment 8818508 [details] Bug 1321416 - remove border to get rid of scrollbar in top level synthetic video document. https://reviewboard.mozilla.org/r/98582/#review98958

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da688b3fb0f0 remove border to get rid of scrollbar in top level synthetic video document. r=jaws

Tested this issue on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.11 on Firefox Nightly 53.0a1 and I confirm that it's not reproducible anymore.