Since Unbind just does a little bit more work than RemoveChildDoc, I think I'll modify it to delegate the shared stuff to RemoveChildDoc.

Comment on attachment 8816237 [details] [diff] [review] Make Unbind delegate some work to RemoveChildDoc > /* > * Called when the document in the content process this object represents >- * notifies the main process a child document has been removed. >+ * notifies the main process a child document has been removed. It is also >+ * called as part of an Unbind. unbind isn't really a high level operation that I think makes sense, does it make more sense to just say called to remove a child document from its parent. > */ > void RemoveChildDoc(DocAccessibleParent* aChildDoc) > { > aChildDoc->Parent()->SetChildDoc(nullptr); > mChildDocs.RemoveElement(aChildDoc); > aChildDoc->mParentDoc = nullptr; > MOZ_ASSERT(aChildDoc->mChildDocs.Length() == 0); I'm not sure that needs to hold in the case its called from Unbind() but I guess we can fix that if it comes up.

Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dbdc4e234e1f Make DocAccessibleParent::Unbind delegate to DocAccessibleParent::RemoveChildDoc; r=tbsaunde

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbdc4e234e1f129f8a475a8709fa5e672fc93a34 Bug 1321622: Make DocAccessibleParent::Unbind delegate to DocAccessibleParent::RemoveChildDoc; r=tbsaunde

Comment on attachment 8816237 [details] [diff] [review] Make Unbind delegate some work to RemoveChildDoc Approval Request Comment [Feature/Bug causing the regression]: a11y+e10s [User impact if declined]: Correctness and/or stability problems. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Trivial patch [String changes made/needed]: None

Comment on attachment 8816237 [details] [diff] [review] Make Unbind delegate some work to RemoveChildDoc a11y/e10s fix for aurora52