Closed
Bug 1321644
Opened 8 years ago
Closed 8 years ago
Remove calls to AndroidBridge::PostTaskToUiThread from APZ
Categories
(GeckoView :: General, defect)
GeckoView
General
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
Once GeckoView support nsThread and MessageLoop in the Android UI thread, it will no longer be necessary to have code that calls AndroidBridge::PostTaskToUiThread for dispatching to the UI/Controller thread.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → rbarker
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8816273 -
Flags: review?(nchen)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8816273 -
Flags: review?(nchen)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8816273 [details] [diff] [review]
0001-Bug-1321642-Add-missing-include-guards-to-nsDeviceContextAndroid.h-16120113-1ac30dc.patch
Attached to wrong bug
Attachment #8816273 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•8 years ago
|
||
|
|
Assignee | |
Comment 4•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8816275 -
Flags: review?(botond)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8816276 -
Flags: review?(botond)
|
||
Updated•8 years ago
|
Attachment #8816275 -
Flags: review?(botond) → review+
|
|
||
Updated•8 years ago
|
Attachment #8816276 -
Flags: review?(botond) → review+
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c25bce77b775
part 1, Remove android specific message loop code from APZThreadUtils.cpp r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ba1893ecf3
part 2, Remove AndroidBridge::PostTaskToUiThread from RemoteContentController.cpp r=botond
I had to back this (and the other bug from your push) out for android xpcshell bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=40966554&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0840950a19b8d610f4974d8f2d908866bfa7493
Flags: needinfo?(rbarker)
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(rbarker)
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d6700b6e2c
part 1, Remove android specific message loop code from APZThreadUtils.cpp r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7b4a449847
part 2, Remove AndroidBridge::PostTaskToUiThread from RemoteContentController.cpp r=botond
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/98d6700b6e2c
https://hg.mozilla.org/mozilla-central/rev/fb7b4a449847
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Target Milestone: Firefox 53 → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•