Closed
Bug 1321820
Opened 8 years ago
Closed 8 years ago
Storage Inspector fails with dom.caches.enabled=false
Categories
(DevTools :: Storage Inspector, defect, P2)
Tracking
(firefox53 fixed)
RESOLVED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: wavexx, Assigned: miker)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20161201031821
Steps to reproduce:
Set dom.caches.enabled=false in the prefs.
Open the storage inspector. The "Caches" tree is now hidden, but the remaining storage options (local/session storage, cookies) do not work any longer.
Actual results:
The following is shown the browser console:
A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Date: Fri Dec 02 2016 16:45:17 GMT+0100 (CET)
Full Message: TypeError: CacheStorage is not a constructor
Full Stack: .getCachesForHost<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/storage.js:1146:17
TaskImpl.prototype._run@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:311:39
TaskImpl@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:273:3
createAsyncFunction/asyncFunction@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/task.js:247:14
.populateStoresForHost<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/server/actors/storage.js:1222:24
TaskImpl.prototype._run@resource://gre/modules/commonjs/toolkit/loader.js -> resource
Expected results:
If dom.caches.enabled is kept as a pref, the storage inspector shouldn't fail if it is set to false.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
To be clear, this pref disables the DOM cache (otherwise known as the service worker cache).
Assignee: nobody → mratcliffe
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8821562 [details]
Bug 1321820 - Storage Inspector fails with dom.caches.enabled=false
https://reviewboard.mozilla.org/r/100806/#review101314
> Because this bug is only caused when a major browser feature is disabled there is no need for a test in the same way that we don't try switching JavaScript off and using the debugger.
I will argue that it would be nice to have a test to make sure the storage inspector is really not "broken" when dom.caches.enabled is set to false. What do you think ?
It would be even better to display some kind of message in the panel to tell the user why there isn't anything in this panel ("Since you set dom.caches.enabled to false, there isn't anything to see here", or something like that. It might be a good thing to do as a follow-up.
Assignee | ||
Comment 4•8 years ago
|
||
There is no hurry... I will add a test and see about adding some kind of messaging system.
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Nicolas Chevobbe [:nchevobbe] from comment #3)
> Comment on attachment 8821562 [details]
> Bug 1321820 - Storage Inspector fails with dom.caches.enabled=false
>
> https://reviewboard.mozilla.org/r/100806/#review101314
>
> > Because this bug is only caused when a major browser feature is disabled there is no need for a test in the same way that we don't try switching JavaScript off and using the debugger.
>
> I will argue that it would be nice to have a test to make sure the storage
> inspector is really not "broken" when dom.caches.enabled is set to false.
> What do you think ?
> It would be even better to display some kind of message in the panel to tell
> the user why there isn't anything in this panel ("Since you set
> dom.caches.enabled to false, there isn't anything to see here", or something
> like that. It might be a good thing to do as a follow-up.
If we decide to act on all of the Firefox prefs we are entering a very large rabbit hole.
I think in this instance you are right though... I have created bug 1325650 to display a message in each storage panel's table when that storage type is preffed off.
I will still add a test with this patch though.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
Added test.
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8821562 [details]
Bug 1321820 - Storage Inspector fails with dom.caches.enabled=false
https://reviewboard.mozilla.org/r/100806/#review101346
Looks good !
r+ assuming TRY is green
Attachment #8821562 -
Flags: review?(chevobbe.nicolas) → review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63b00cc7babb
Storage Inspector fails with dom.caches.enabled=false r=nchevobbe
Comment 10•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•