Closed Bug 1321981 Opened 8 years ago Closed 8 years ago

[RTL] Swiping gesture between Top Sites, Bookmarks and History in a New Tab is reversed

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P2)

All
Android
defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: itiel_yn8, Assigned: maliu)

References

Details

(Keywords: rtl)

Attachments

(4 files)

In latest Nightly builds, swiping from one section in a New Tab to another is reversed. STR: 1. Install RTL Nightly build of Firefox for Android 2. Open a New Tab 3. Swipe RIGHT to go to Bookmarks -> nothing happens 4. Swipe LEFT (nothing should happen) -> Firefox goes to Bookmarks In short, swiping right should go left, and swiping left should go right. Same as in LTR builds.
I am able to reproduce this. Max, is this something the framework permits?
Flags: needinfo?(max)
QA Contact: ioana.chiorean
Hardware: Unspecified → All
(In reply to Ioana Chiorean from comment #1) > I am able to reproduce this. > Max, is this something the framework permits? The root cause of this bug is that we use ViewPager from google supoprt library that does not support RTL. Better solution could be replacing it with RecyclerView and some scrolling tweak. Unfortunately, we probable have not enough time to fix it before 53 merge.
Flags: needinfo?(max)
Max any updates here?
Flags: needinfo?(max)
(In reply to Ioana Chiorean from comment #3) > Max any updates here? I found a solution for this bug. But I need to check with Sebastian to confirm our external open source library policy. The patch should be low risk for uplift. I'll try to land the patch before next week;
Flags: needinfo?(max)
Assignee: nobody → max
Status: NEW → ASSIGNED
Comment on attachment 8849458 [details] Bug 1321981 - [RTL] ViewPager Support - part 1. Import thirdparty RtlViewPager, https://reviewboard.mozilla.org/r/122236/#review124380
Attachment #8849458 - Flags: review?(s.kaspari) → review+
Comment on attachment 8849459 [details] Bug 1321981 - [RTL] ViewPager Support - part 2. Notify dataset change with calling super, https://reviewboard.mozilla.org/r/122238/#review124382
Attachment #8849459 - Flags: review?(s.kaspari) → review+
Comment on attachment 8849460 [details] Bug 1321981 - [RTL] ViewPager Support - part 3. Skip set current item if adapter is empty, https://reviewboard.mozilla.org/r/122240/#review124384
Attachment #8849460 - Flags: review?(s.kaspari) → review+
Comment on attachment 8849461 [details] Bug 1321981 - [RTL] ViewPager Support - part 4. Switch to RtlViewPager, https://reviewboard.mozilla.org/r/122242/#review124386
Attachment #8849461 - Flags: review?(s.kaspari) → review+
Pushed by max@mxli.us: https://hg.mozilla.org/integration/autoland/rev/094d01c3c450 [RTL] ViewPager Support - part 1. Import thirdparty RtlViewPager, r=sebastian https://hg.mozilla.org/integration/autoland/rev/e0c93b49a773 [RTL] ViewPager Support - part 2. Notify dataset change with calling super, r=sebastian https://hg.mozilla.org/integration/autoland/rev/b03a53a62cfe [RTL] ViewPager Support - part 3. Skip set current item if adapter is empty, r=sebastian https://hg.mozilla.org/integration/autoland/rev/2ed5a83f2ae2 [RTL] ViewPager Support - part 4. Switch to RtlViewPager, r=sebastian
Blocks: 1337440
This seems to work very well in latest Nightly. Can someone with a tablet also confirm?
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: