We know that we sometimes inherit styles differently from stock Gecko, particularly around anonymous boxes. We should disable the style context tree structure verification assertions, at least for now.

As a record, I discussed with heycam offline, and I think it is usually harder to enable something after we disable it, especially this kind of debug-only things. I suggest that we should probably investigate more detailedly which assertions could be broken with stylo, and evaluate based on that whether we should disable the whole DebugVerifyStyleTree, conditionally disable it in some conditions, or just fix assertions show up.

Comment on attachment 8817516 [details] [diff] [review] patch So cancel r? for now.

We're hitting these assertions all over the place, so this is probably a good thing for Boris to look at.

At this point these assertions are more noise than anything, given that the style context tree structure is far less important with stylo (as we use don't use the structure for property inheritance).

Moving the needinfo to bug 1322570.

Comment on attachment 8817516 [details] [diff] [review] patch Review of attachment 8817516 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/RestyleManagerBase.cpp @@ +379,5 @@ > RestyleManagerBase::DebugVerifyStyleTree(nsIFrame* aFrame) > { > + if (IsServo()) { > + // XXXheycam For now, we know that we don't use the same inheritance > + // hierarchy for certain cases, so just skip these assertions. Please reference the bug for potentially re-enabling them if they make sense.

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a365beac4010 Disable style context tree structure verification assertions in stylo. r=bholley

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3cc0791a7aad Followup bustage fix on a CLOSED TREE.

https://hg.mozilla.org/mozilla-central/rev/a365beac4010 https://hg.mozilla.org/mozilla-central/rev/3cc0791a7aad