Closed
Bug 1322577
Opened 8 years ago
Closed 3 years ago
[geckoview] Add header support to GeckoView.loadUri()
Categories
(GeckoView :: General, defect, P3)
GeckoView
General
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: snorp, Unassigned)
References
Details
Specifically, the flags are just wrong, since we don't support tabs. I think the flags should basically reflect whatever makes sense from nsLoadFlags (bypass cache, only use cache, etc).
Also, I think we want to be able to pass in some headers. Just a map of strings should be fine there, I think.
Comment 1•8 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0)
> Specifically, the flags are just wrong, since we don't support tabs. I think
> the flags should basically reflect whatever makes sense from nsLoadFlags
> (bypass cache, only use cache, etc).
>
> Also, I think we want to be able to pass in some headers. Just a map of
> strings should be fine there, I think.
To make this actually work in GeckoView, you need to define the nsIBrowserAccess interface, like at http://searchfox.org/mozilla-central/source/mobile/android/chrome/content/browser.js#360. I have a hacky implementation this locally which I will try to push out.
Reporter | ||
Updated•7 years ago
|
Component: Embedding: APIs → GeckoView
Product: Core → Firefox for Android
Version: unspecified → Trunk
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → snorp
Priority: -- → P1
Summary: [geckoview] Update GeckoView.loadUri() → [geckoview] Add flags/header support to GeckoView.loadUri()
Reporter | ||
Comment 3•7 years ago
|
||
We have flags now, but still no headers.
Summary: [geckoview] Add flags/header support to GeckoView.loadUri() → [geckoview] Add header support to GeckoView.loadUri()
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Comment 5•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:amoya, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: snorp → nobody
Flags: needinfo?(amoya)
Comment 6•3 years ago
|
||
This has been supported for some time in GeckoView; see, for example, https://searchfox.org/mozilla-central/rev/82946eb5e7d1234f3218310e7bc8a394666dbda5/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#1549-1554.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
Updated•2 years ago
|
Flags: needinfo?(amoya)
You need to log in
before you can comment on or make changes to this bug.
Description
•