Closed Bug 1322785 Opened 8 years ago Closed 8 years ago

Geolocation can not be allowed permanently

Categories

(Firefox :: Site Identity, defect, P2)

Product:
Firefox
Component:
Site Identity
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- verified
firefox54 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Keywords: regression, Whiteboard: [fxprivacy] )

Attachments

(1 file)

Bug 1322785 - Add tests for geolocation and desktop notification prompts.
(deleted), text/x-review-board-request
Paolo
: review+
Details
STR: - Go to permission.site - Click on "Location" - Select "Remember this decision" - Note that the decision is indeed not remembered. This will be fixed by bug 1206232, but I wanted to make a separate bug to track this issue and verify that it's actually fixed. Additionally we should really have a test for this.
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Erin, did you intentionally remove the triage tag without setting a priority?
Flags: needinfo?(elancaster)
Likely since this will be fixed by a patch in a different ticket bug 1206232. I'm happy to just have this bug inherit the same priority/asssignee.
Assignee: nobody → jhofmann
Priority: -- → P2
Flags: needinfo?(elancaster)
This was just fixed in by bug 1206232 but I'll write up a test to verify and protect against further regressions.
Flags: qe-verify+
This is adding some tests for modules introduced in bug 1297475 that weren't tested in that bug.
Comment on attachment 8827407 [details] Bug 1322785 - Add tests for geolocation and desktop notification prompts. https://reviewboard.mozilla.org/r/105094/#review106356 Thanks for adding the tests for the more specific objects! I wish we could share more code. Even though it's testing a different thing, the new test has this weird cut-and-paste look...
Attachment #8827407 - Flags: review?(paolo.mozmail) → review+
I agree, it doesn't look too great. We probably could share more with a bit more effort, but for now I'm happy to not invest more time into that. If we ever add more tests here this will definitely catch our attention again.
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/abb7ae94f6ec Add tests for geolocation and desktop notification prompts. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/abb7ae94f6ec
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Verified as fixed on Ubuntu 16.04 x64, Windows 10 x 64 and Mac OS X 10.11 on Firefox Nightly 53.0a1, Firefox Nightly 54.0a1 and Aurora 53.0a2.
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
status-firefox54: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: