Johann Hofmann [:johannh] Assignee
	Description • 8 years ago

STR:

- Go to permission.site
- Click on "Location"
- Select "Remember this decision"
- Note that the decision is indeed not remembered.

This will be fixed by bug 1206232, but I wanted to make a separate bug to track this issue and verify that it's actually fixed. Additionally we should really have a test for this.

	Florian Quèze [:florian]
	Comment 1 • 8 years ago

Erin, did you intentionally remove the triage tag without setting a priority?

	Erin Lancaster [:elan]
	Comment 2 • 8 years ago

Likely since this will be fixed by a patch in a different ticket bug 1206232. I'm happy to just have this bug inherit the same priority/asssignee.

	Johann Hofmann [:johannh] Assignee
	Comment 3 • 8 years ago

This was just fixed in by bug 1206232 but I'll write up a test to verify and protect against further regressions.

	Johann Hofmann [:johannh] Assignee
	Comment 5 • 8 years ago

This is adding some tests for modules introduced in bug 1297475 that weren't tested in that bug.

	:Paolo Amadini
	Comment 6 • 8 years ago
mozreview-review

Comment on attachment 8827407 [details]
Bug 1322785 - Add tests for geolocation and desktop notification prompts.

https://reviewboard.mozilla.org/r/105094/#review106356

Thanks for adding the tests for the more specific objects!

I wish we could share more code. Even though it's testing a different thing, the new test has this weird cut-and-paste look...

	Johann Hofmann [:johannh] Assignee
	Comment 7 • 8 years ago

I agree, it doesn't look too great. We probably could share more with a bit more effort, but for now I'm happy to not invest more time into that. If we ever add more tests here this will definitely catch our attention again.

	Pulsebot
	Comment 8 • 8 years ago

Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abb7ae94f6ec
Add tests for geolocation and desktop notification prompts. r=Paolo

	Carsten Book [:Tomcat]
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/abb7ae94f6ec

	Hani Yacoub, Desktop QA
	Comment 11 • 8 years ago

Verified as fixed on Ubuntu 16.04 x64, Windows 10 x 64 and Mac OS X 10.11 on Firefox Nightly 53.0a1, Firefox Nightly 54.0a1 and Aurora 53.0a2.