Closed
Bug 1322816
Opened 8 years ago
Closed 8 years ago
Deal with giant textures
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
Right now webrender doesn't seem to handle giant textures. These two reftests crash webrender:
layout/reftests/bugs/632781-verybig.html
layout/reftests/canvas/size-1.html
and I'm disabling them in bug 1319188. This bug is to re-enable them.
Assignee | ||
Comment 1•8 years ago
|
||
For reference, running the 632781-verybig.html reftest produces this in the output:
REFTEST TEST-LOAD | file:///home/kats/zspace/mozilla-w2/layout/reftests/bugs/632781-verybig.html | 0 / 1 (0%)
thread '<unnamed>' panicked at 'assertion failed: allocation_size.width < max_texture_size()', /home/kats/zspace/mozilla-w2/gfx/webrender/src/texture_cache.rs:648
where the assertion that's failing is https://hg.mozilla.org/projects/graphics/file/73bdd29461ae/gfx/webrender/src/texture_cache.rs#l648
Assignee | ||
Updated•8 years ago
|
See Also: → https://github.com/servo/webrender/issues/652
Assignee | ||
Comment 2•8 years ago
|
||
There are some crashtests that also run into this assertion:
dom/canvas/crashtests/780392-1.html
dom/canvas/crashtests/789933-1.html
dom/media/test/crashtests/789075-1.html
I'll be disabling these soon in order to enable the crashtests on QR builds in automation.
Assignee | ||
Comment 3•8 years ago
|
||
The WR issue is closed, I'll retest these crashtests and see what happens.
Assignee | ||
Comment 4•8 years ago
|
||
Assignee | ||
Comment 5•8 years ago
|
||
Seems to be working, except for one failure. Still, fails-if is better than skip-if.
Final patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d704964dd009a1813e7699c980406707ff156fb
Assignee: nobody → bugmail
Comment hidden (mozreview-request) |
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8850078 [details]
Bug 1322816 - Re-enable some skipped reftests now that WebRender handles them.
https://reviewboard.mozilla.org/r/122802/#review125022
Attachment #8850078 -
Flags: review?(rhunt) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/62409ff101f1
Re-enable some skipped reftests now that WebRender handles them. r=rhunt
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•8 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•