Closed
Bug 132320
Opened 23 years ago
Closed 23 years ago
Failed FTP login doesn't give any error status
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
WORKSFORME
mozilla1.0
People
(Reporter: cmanske, Assigned: adamlock)
References
Details
(Whiteboard: PUBLISHING)
Use Composer to publish any file to an ftp publishing address.
(File | Publish As brings up Publishing dialog.)
If either required username or password is missing or incorrect, we get a
call to nsIPrompt::alert notification with the message "Login incorrect", but
no error codes in either nsIWebProgressListener::onStatusChange() or
nsIWebProgressListener::onStateChange()
For the latter, I would expect a non-zero "aStatus" param for the
(STATE_STOP | STATE_IS_NETWORK) call that we use to know when an FTP transfer
has finished. Note that after this error, the window caption now shows the
remote URL because Composer thinks the FTP transfer has succeeded when it hasn't.
Optimally, we should get a nsIWebProgressListener::onStatusChange() call with a
unique aStatus value that tells us a login failed. If this were sent just before
the nsIPrompt::alert() call, we could put up a different dialog letting the
user correct the username and/or password and try to publish again.
This is what I was hoping to do to fix the problem described in bug 124561 and
bug 124480. But we need error codes to be able to let user fix username password
errors.
Mininally, the aStatus when calling nsIWebProgressListener::onStateChange()
when the FTP is finished must have a non-zero value.
Reporter | ||
Updated•23 years ago
|
Comment 1•23 years ago
|
||
This bug is with the nsIWebProgressListener::onStateChange code. FTP does fire
an OnStopRequest with a status.
See:
http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp#2311
Where we set the internal error:
http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp#741
I do not think FTP is doing something wrong.
Rick, what do I need to do to have the status pass through to the client's
nsIWebProgressListener
Assignee: dougt → adamlock
Component: Networking: FTP → Embedding: Docshell
QA Contact: benc → adamlock
Reporter | ||
Comment 2•23 years ago
|
||
This seems to be magically fixed in today's build. We now get the aStatus value
= ACCESS_DENIED, so all is well.
It is April Fools Day, after all :)
I will let Doug and Adam confirm and close this bug.
Comment 3•23 years ago
|
||
This WFM in a trunk build from this afternoon. Gotta love wild goose chases on
a Monday. :-)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•