Closed
Bug 1323399
Opened 8 years ago
Closed 8 years ago
[Stylo] Fix the stylo-vs-gecko reftest harness
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: shinglyu, Assigned: shinglyu)
References
Details
Attachments
(1 file)
Our old stylo-vs-gecko reftest patch had probably landed on the private github repo. I'm trying to land them again onto m-c so they are actually run on try pushes.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
This is a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=82a813d1bd1df2a9c4e3a0733c6de62d08f27a44
If you look into the reftest log you can actually see the "Enable/Disable Servo-backed style system" messages, which indicates that we are comparing stylo versus gecko.
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8818498 [details]
Bug 1323399 - Fix the stylo-vs-gecko reftest harness.
https://reviewboard.mozilla.org/r/98574/#review98830
::: layout/tools/reftest/reftest.jsm:58
(Diff revision 1)
> +#ifdef MOZ_STYLO
> +var gCompareStyloToGecko = false;
> +#endif
I think we can get rid of the #ifdefs around this.
::: layout/tools/reftest/reftest.jsm:1318
(Diff revision 1)
> gState = aState;
> gCurrentURL = gURLs[0]["url" + aState].spec;
>
> RestoreChangedPreferences();
>
> +#ifdef MOZ_STYLO
And this one. But then keep the one above that could set gCompareStyloToGecko to true.
::: layout/tools/reftest/reftest.jsm:1320
(Diff revision 1)
> + var prefs = Components.classes["@mozilla.org/preferences-service;1"].
> + getService(Components.interfaces.nsIPrefBranch);
Please move this up to the top level of the function, outside the #ifdef MOZ_STYLO, and then remove the equivalent |var prefs| that's in the |if (prefSettings.length > 0| below.
::: layout/tools/reftest/reftest.jsm:1323
(Diff revision 1)
> +#ifdef MOZ_STYLO
> + if (gCompareStyloToGecko) {
> + var prefs = Components.classes["@mozilla.org/preferences-service;1"].
> + getService(Components.interfaces.nsIPrefBranch);
> + if (gState == 2){
> + logger.info("Disalbing Servo-backed style system");
*Disabling
Attachment #8818498 -
Flags: review?(cam) → review+
Comment hidden (mozreview-request) |
Pushed by slyu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c4fa2b29abe7
Fix the stylo-vs-gecko reftest harness. r=heycam
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•8 years ago
|
Blocks: stylo-central
Updated•7 years ago
|
Assignee: nobody → shing.lyu
You need to log in
before you can comment on or make changes to this bug.
Description
•