Closed Bug 1323671 Opened 8 years ago Closed 8 years ago

stylo: several tests panic with "assertion failed: !el.has_dirty_descendants()"

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: heycam, Assigned: bholley)

References

Details

thread '<unnamed>' panicked at 'assertion failed: !el.has_dirty_descendants()', /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:872 stack backtrace: 1: 0x7fffea9ba11f - std::sys::backtrace::tracing::imp::write::hd6ece0fd16ebfe06 2: 0x7fffea9c967d - std::panicking::default_hook::{{closure}}::h523f1cb7f97bbc83 3: 0x7fffea9c6bda - std::panicking::default_hook::hc3c81c24cdcc8c31 4: 0x7fffea9c71d8 - std::panicking::rust_panic_with_hook::hf4b937f570e0ba05 5: 0x7fffe9d4dda3 - std::panicking::begin_panic::hcb26c0e753df7acf at /buildslave/rust-buildbot/slave/beta-dist-rustc-linux/build/obj/../src/libstd/panicking.rs:413 6: 0x7fffe9eae83a - geckoservo::glue::Servo_AssertTreeIsClean::assert_subtree_is_clean::h5f0ef4c15c2f0a3e at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:872 7: 0x7fffe9eae954 - geckoservo::glue::Servo_AssertTreeIsClean::assert_subtree_is_clean::h5f0ef4c15c2f0a3e at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:875 8: 0x7fffe9eae954 - geckoservo::glue::Servo_AssertTreeIsClean::assert_subtree_is_clean::h5f0ef4c15c2f0a3e at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:875 9: 0x7fffe9eae7d4 - Servo_AssertTreeIsClean at /z/stylo/hg-incubator/servo/ports/geckolib/glue.rs:880 10: 0x7fffe6d28a17 - _ZN7mozilla13ServoStyleSet17AssertTreeIsCleanEv at /z/stylo/hg-incubator/layout/style/ServoStyleSet.cpp:482 11: 0x7fffe6f270e5 - _ZN7mozilla19ServoRestyleManager22ProcessPendingRestylesEv at /z/stylo/hg-incubator/layout/base/ServoRestyleManager.cpp:336 12: 0x7fffe6f2ed3c - _ZN7mozilla20RestyleManagerHandle3Ptr22ProcessPendingRestylesEv at /z/stylo/hg-incubator/obj/dist/include/mozilla/RestyleManagerHandleInlines.h:75 13: 0x7fffe6ef92a9 - _ZN7mozilla9PresShell25FlushPendingNotificationsENS_14ChangesToFlushE at /z/stylo/hg-incubator/layout/base/PresShell.cpp:4115 14: 0x7fffe6ef8c9f - _ZN7mozilla9PresShell25FlushPendingNotificationsE12mozFlushType at /z/stylo/hg-incubator/layout/base/PresShell.cpp:4007 15: 0x7fffe48a6bf1 - _ZN10nsDocument25FlushPendingNotificationsE12mozFlushType at /z/stylo/hg-incubator/dom/base/nsDocument.cpp:7756 16: 0x7fffe6d960b7 - _ZN18nsComputedDOMStyle25UpdateCurrentStyleSourcesEb at /z/stylo/hg-incubator/layout/style/nsComputedDOMStyle.cpp:634 17: 0x7fffe6d96a9c - _ZN18nsComputedDOMStyle19GetPropertyCSSValueERK18nsAString_internalRN7mozilla11ErrorResultE at /z/stylo/hg-incubator/layout/style/nsComputedDOMStyle.cpp:797 18: 0x7fffe6d95db9 - _ZN18nsComputedDOMStyle16GetPropertyValueERK18nsAString_internalRS0_ at /z/stylo/hg-incubator/layout/style/nsComputedDOMStyle.cpp:379 19: 0x7fffe6b76fdb - _ZN7mozilla12CSSEditUtils24GetCSSInlinePropertyBaseEP7nsINodeP7nsIAtomR18nsAString_internalNS0_9StyleTypeE at /z/stylo/hg-incubator/editor/libeditor/CSSEditUtils.cpp:540 20: 0x7fffe6b77292 - _ZN7mozilla12CSSEditUtils19GetComputedPropertyER7nsINodeR7nsIAtomR18nsAString_internal at /z/stylo/hg-incubator/editor/libeditor/CSSEditUtils.cpp:519 21: 0x7fffe6ba7680 - _ZN7mozilla10HTMLEditor41GetAbsolutelyPositionedSelectionContainerEPP13nsIDOMElement at /z/stylo/hg-incubator/editor/libeditor/HTMLAbsPositionEditor.cpp:91 22: 0x7fffe6bbc9f4 - _ZN7mozilla10HTMLEditor38CheckSelectionStateForAnonymousButtonsEP12nsISelection at /z/stylo/hg-incubator/editor/libeditor/HTMLAnonymousNodeEditor.cpp:353 23: 0x7fffe6c237e7 - _ZN7mozilla10HTMLEditor18EndUpdateViewBatchEv at /z/stylo/hg-incubator/editor/libeditor/HTMLEditor.cpp:4844 24: 0x7fffe6b87e85 - _ZN7mozilla10EditorBase25EndPlaceHolderTransactionEv at /z/stylo/hg-incubator/editor/libeditor/EditorBase.cpp:966 25: 0x7fffe6bb4812 - _ZN7mozilla20AutoPlaceHolderBatchD2Ev at /z/stylo/hg-incubator/obj/dist/include/mozilla/EditorUtils.h:170 26: 0x7fffe6bafaee - _ZN7mozilla13AutoEditBatchD2Ev at /z/stylo/hg-incubator/obj/dist/include/mozilla/EditorUtils.h:192 27: 0x7fffe6c28543 - _ZN7mozilla10HTMLEditor23DoInsertHTMLWithContextERK18nsAString_internalS3_S3_S3_P14nsIDOMDocumentP10nsIDOMNodeibbb at /z/stylo/hg-incubator/editor/libeditor/HTMLEditorDataTransfer.cpp:674 28: 0x7fffe6c24d15 - _ZN7mozilla10HTMLEditor21InsertHTMLWithContextERK18nsAString_internalS3_S3_S3_P14nsIDOMDocumentP10nsIDOMNodeib at /z/stylo/hg-incubator/editor/libeditor/HTMLEditorDataTransfer.cpp:183 29: 0x7fffe6c24c74 - _ZN7mozilla10HTMLEditor10InsertHTMLERK18nsAString_internal at /z/stylo/hg-incubator/editor/libeditor/HTMLEditorDataTransfer.cpp:169 30: 0x7fffe6ca59c4 - _ZN19nsInsertHTMLCommand15DoCommandParamsEPKcP16nsICommandParamsP11nsISupports at /z/stylo/hg-incubator/editor/composer/nsComposerCommands.cpp:1329 31: 0x7fffe77b09a1 - _ZN24nsControllerCommandTable15DoCommandParamsEPKcP16nsICommandParamsP11nsISupports at /z/stylo/hg-incubator/embedding/components/commandhandler/nsControllerCommandTable.cpp:162 32: 0x7fffe77abe8f - _ZN23nsBaseCommandController19DoCommandWithParamsEPKcP16nsICommandParams at /z/stylo/hg-incubator/embedding/components/commandhandler/nsBaseCommandController.cpp:152 33: 0x7fffe77aeda6 - _ZN16nsCommandManager9DoCommandEPKcP16nsICommandParamsP18mozIDOMWindowProxy at /z/stylo/hg-incubator/embedding/components/commandhandler/nsCommandManager.cpp:212 34: 0x7fffe5de5710 - _ZN14nsHTMLDocument11ExecCommandERK18nsAString_internalbS2_N7mozilla3dom10CallerTypeERNS3_11ErrorResultE at /z/stylo/hg-incubator/dom/html/nsHTMLDocument.cpp:3259 35: 0x7fffe5699781 - _ZN7mozilla3dom19HTMLDocumentBindingL11execCommandEP9JSContextN2JS6HandleIP8JSObjectEEP14nsHTMLDocumentRK19JSJitMethodCallArgs at /z/stylo/hg-incubator/obj/dom/bindings/HTMLDocumentBinding.cpp:829 36: 0x7fffe58aa6f1 - _ZN7mozilla3dom20GenericBindingMethodEP9JSContextjPN2JS5ValueE at /z/stylo/hg-incubator/dom/bindings/BindingUtils.cpp:2886 37: 0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239 38: 0x7fffe968b46f - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:457 39: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 40: 0x7fffe968b66c - _ZN2js13CallFromStackEP9JSContextRKN2JS8CallArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:508 41: 0x7fffe967fe75 - _ZL9InterpretP9JSContextRN2js8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:2919 42: 0x7fffe96752cf - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:403 43: 0x7fffe968b567 - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:475 44: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 45: 0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521 46: 0x7fffe937d1af - _ZN2JS4CallEP9JSContextNS_6HandleINS_5ValueEEES4_RKNS_16HandleValueArrayENS_13MutableHandleIS3_EE at /z/stylo/hg-incubator/js/src/jsapi.cpp:2830 47: 0x7fffe554500c - _ZN7mozilla3dom13EventListener11HandleEventEP9JSContextN2JS6HandleINS4_5ValueEEERNS0_5EventERNS_11ErrorResultE at /z/stylo/hg-incubator/obj/dom/bindings/EventListenerBinding.cpp:47 48: 0x7fffe5b800e5 - _ZN7mozilla3dom13EventListener11HandleEventIPNS0_11EventTargetEEEvRKT_RNS0_5EventERNS_11ErrorResultEPKcNS0_14CallbackObject17ExceptionHandlingEP13JSCompartment at /z/stylo/hg-incubator/obj/dist/include/mozilla/dom/EventListenerBinding.h:64 49: 0x7fffe5b60852 - _ZN7mozilla20EventListenerManager18HandleEventSubTypeEPNS0_8ListenerEP11nsIDOMEventPNS_3dom11EventTargetE at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1130 50: 0x7fffe5b60fbd - _ZN7mozilla20EventListenerManager19HandleEventInternalEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus at /z/stylo/hg-incubator/dom/events/EventListenerManager.cpp:1286 51: 0x7fffe5b8af7c - _ZN7mozilla20EventListenerManager11HandleEventEP13nsPresContextPNS_11WidgetEventEPP11nsIDOMEventPNS_3dom11EventTargetEP13nsEventStatus at /z/stylo/hg-incubator/obj/dist/include/mozilla/EventListenerManager.h:374 52: 0x7fffe5b7dd37 - _ZN7mozilla20EventTargetChainItem11HandleEventERNS_21EventChainPostVisitorERNS_19ELMCreationDetectorE at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:314 53: 0x7fffe5b5893e - _ZN7mozilla20EventTargetChainItem22HandleEventTargetChainER8nsTArrayIS0_ERNS_21EventChainPostVisitorEPNS_24EventDispatchingCallbackERNS_19ELMCreationDetectorE at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:487 54: 0x7fffe5b59dde - _ZN7mozilla15EventDispatcher8DispatchEP11nsISupportsP13nsPresContextPNS_11WidgetEventEP11nsIDOMEventP13nsEventStatusPNS_24EventDispatchingCallbackEP8nsTArrayIPNS_3dom11EventTargetEE at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:820 55: 0x7fffe5b5a358 - _ZN7mozilla15EventDispatcher16DispatchDOMEventEP11nsISupportsPNS_11WidgetEventEP11nsIDOMEventP13nsPresContextP13nsEventStatus at /z/stylo/hg-incubator/dom/events/EventDispatcher.cpp:886 56: 0x7fffe4939284 - _ZN7nsINode13DispatchEventEP11nsIDOMEventPb at /z/stylo/hg-incubator/dom/base/nsINode.cpp:1298 57: 0x7fffe5b65493 - _ZN7mozilla3dom11EventTarget13DispatchEventERNS0_5EventENS0_10CallerTypeERNS_11ErrorResultE at /z/stylo/hg-incubator/dom/events/EventTarget.cpp:73 58: 0x7fffe55a566f - _ZN7mozilla3dom18EventTargetBindingL13dispatchEventEP9JSContextN2JS6HandleIP8JSObjectEEPNS0_11EventTargetERK19JSJitMethodCallArgs at /z/stylo/hg-incubator/obj/dom/bindings/EventTargetBinding.cpp:970 59: 0x7fffe55a4696 - _ZN7mozilla3dom18EventTargetBindingL13genericMethodEP9JSContextjPN2JS5ValueE at /z/stylo/hg-incubator/obj/dom/bindings/EventTargetBinding.cpp:1146 60: 0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239 61: 0x7fffe968b46f - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:457 62: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 63: 0x7fffe968b66c - _ZN2js13CallFromStackEP9JSContextRKN2JS8CallArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:508 64: 0x7fffe967fe75 - _ZL9InterpretP9JSContextRN2js8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:2919 65: 0x7fffe96752cf - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:403 66: 0x7fffe968b567 - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:475 67: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 68: 0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521 69: 0x7fffe93d7822 - _ZN2js9fun_applyEP9JSContextjPN2JS5ValueE at /z/stylo/hg-incubator/js/src/jsfun.cpp:1223 70: 0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239 71: 0x7fffe968b46f - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:457 72: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 73: 0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521 74: 0x7fffe951ecb5 - _ZNK2js7Wrapper4callEP9JSContextN2JS6HandleIP8JSObjectEERKNS3_8CallArgsE at /z/stylo/hg-incubator/js/src/proxy/Wrapper.cpp:165 75: 0x7fffe9508db0 - _ZNK2js23CrossCompartmentWrapper4callEP9JSContextN2JS6HandleIP8JSObjectEERKNS3_8CallArgsE at /z/stylo/hg-incubator/js/src/proxy/CrossCompartmentWrapper.cpp:333 76: 0x7fffe950e2f4 - _ZN2js5Proxy4callEP9JSContextN2JS6HandleIP8JSObjectEERKNS3_8CallArgsE at /z/stylo/hg-incubator/js/src/proxy/Proxy.cpp:400 77: 0x7fffe950fad3 - _ZN2js10proxy_CallEP9JSContextjPN2JS5ValueE at /z/stylo/hg-incubator/js/src/proxy/Proxy.cpp:689 78: 0x7fffe96a761c - _ZN2js12CallJSNativeEP9JSContextPFbS1_jPN2JS5ValueEERKNS2_8CallArgsE at /z/stylo/hg-incubator/js/src/jscntxtinlines.h:239 79: 0x7fffe968b30b - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:445 80: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 81: 0x7fffe968b66c - _ZN2js13CallFromStackEP9JSContextRKN2JS8CallArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:508 82: 0x7fffe967fe75 - _ZL9InterpretP9JSContextRN2js8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:2919 83: 0x7fffe96752cf - _ZN2js9RunScriptEP9JSContextRNS_8RunStateE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:403 84: 0x7fffe968b567 - _ZN2js23InternalCallOrConstructEP9JSContextRKN2JS8CallArgsENS_14MaybeConstructE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:475 85: 0x7fffe968b86e - _ZL12InternalCallP9JSContextRKN2js13AnyInvokeArgsE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:502 86: 0x7fffe968b8e5 - _ZN2js4CallEP9JSContextN2JS6HandleINS2_5ValueEEES5_RKNS_13AnyInvokeArgsENS2_13MutableHandleIS4_EE at /z/stylo/hg-incubator/js/src/vm/Interpreter.cpp:521 87: 0x7fffe937cabe - _Z20JS_CallFunctionValueP9JSContextN2JS6HandleIP8JSObjectEENS2_INS1_5ValueEEERKNS1_16HandleValueArrayENS1_13MutableHandleIS6_EE at /z/stylo/hg-incubator/js/src/jsapi.cpp:2771 88: 0x7fffe3c27e36 - _ZN19nsXPCWrappedJSClass10CallMethodEP14nsXPCWrappedJStPK19XPTMethodDescriptorP17nsXPTCMiniVariant at /z/stylo/hg-incubator/js/xpconnect/src/XPCWrappedJSClass.cpp:1213 89: 0x7fffe3c26a7f - _ZN14nsXPCWrappedJS10CallMethodEtPK19XPTMethodDescriptorP17nsXPTCMiniVariant at /z/stylo/hg-incubator/js/xpconnect/src/XPCWrappedJS.cpp:613 90: 0x7fffe2b095e4 - PrepareAndDispatch at /z/stylo/hg-incubator/xpcom/reflect/xptcall/md/unix/xptcstubs_x86_64_linux.cpp:122
gfx/tests/crashtests/595727-1.html layout/base/crashtests/404218-1.xhtml
Summary: stylo: gfx/tests/crashtests/595727-1.html panics with "assertion failed: !el.has_dirty_descendants()" → stylo: several tests panic with "assertion failed: !el.has_dirty_descendants()"
layout/style/crashtests/383979-2.html
Depends on: 1326023
Incremental restyle.
Flags: needinfo?(bobbyholley)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2863ca363fe1e38f046e024fe67e021d657b7859&selectedJob=68595232 Looks like these crashes are also fixed by bug 1329854. I'll re-enable these crashtests with that push.
Assignee: nobody → bobbyholley
Depends on: 1329854
Flags: needinfo?(bobbyholley)
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.