Closed
Bug 1323946
Opened 8 years ago
Closed 8 years ago
Use MOZ_MUST_USE in netwerk/protocol/res
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: wcpan, Assigned: wcpan)
References
Details
(Whiteboard: [necko-would-take])
Attachments
(1 file)
Subtask of bug 1303701.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8820575 [details]
Bug 1323946 - Use MOZ_MUST_USE for netwerk/protocol/res
https://reviewboard.mozilla.org/r/100058/#review100688
::: chrome/nsChromeRegistryChrome.cpp:991
(Diff revision 1)
> uri);
> return;
> }
>
> - rph->SetSubstitution(host, resolved);
> + rv = rph->SetSubstitution(host, resolved);
> + MOZ_ASSERT(NS_SUCCEEDED(rv));
Similar to above, if NS_FAILED call LogMessageWithContext
::: layout/style/nsLayoutStylesheetCache.cpp:603
(Diff revision 1)
> if (!handler) {
> annotation.AppendLiteral("(ResolveURI failed)\n");
> } else {
> nsAutoCString resolvedSpec;
> - handler->ResolveURI(aURI, resolvedSpec);
> + DebugOnly<nsresult> rv = handler->ResolveURI(aURI, resolvedSpec);
> + MOZ_ASSERT(NS_SUCCEEDED(rv));
This may fail. I think this would be more appropriate:
```
if (NS_FAILED(rv)) {
annotation.AppendLiteral("(ResolveURI failed rv=)");
annotation.AppendInt(rv);
annotation.AppendLiteral("\n");
}
```
Attachment #8820575 -
Flags: review?(valentin.gosu) → review+
| Comment hidden (mozreview-request) |
Pushed by wpan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c28b3afaa5cd
Use MOZ_MUST_USE for netwerk/protocol/res r=valentin
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•