Closed
Bug 1324173
Opened 8 years ago
Closed 8 years ago
Section titles should not have a colon at the end
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | verified |
People
(Reporter: jaws, Assigned: leftysolara)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See slides 27 and 28 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509
Reporter | ||
Comment 1•8 years ago
|
||
Hey Jalen, would you like to work on this bug next? See the Updates section on the Advanced page of the Preferences. The section titles shouldn't have colons at the end.
You can read https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings and other parts of that page to learn more about how localization (user-facing strings) are used in Firefox.
Since the meaning of the strings aren't changing (just removing the colon), I don't think we need to update the entity's key. Flod, can you confirm?
Flags: needinfo?(leftysolara)
Flags: needinfo?(francesco.lodolo)
Comment 2•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Since the meaning of the strings aren't changing (just removing the colon),
> I don't think we need to update the entity's key. Flod, can you confirm?
In this case I would use a new string ID, mostly to make sure all locales notice the change, and adopt the same consistency en-US is trying to get.
Talking about those slides, I would point out that I don't see a "DRM content" on OS X, but I see a "Automatically update:" with a colon.
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Hey Jalen, would you like to work on this bug next? See the Updates section
> on the Advanced page of the Preferences. The section titles shouldn't have
> colons at the end.
>
> You can read
> https://developer.mozilla.org/en-US/docs/Mozilla/Localization/
> Localization_content_best_practices#Changing_existing_strings and other
> parts of that page to learn more about how localization (user-facing
> strings) are used in Firefox.
>
> Since the meaning of the strings aren't changing (just removing the colon),
> I don't think we need to update the entity's key. Flod, can you confirm?
Sure. I'll get on this as soon as I can.
Flags: needinfo?(leftysolara)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8820471 [details]
Bug 1324173 - Remove colon from end of section titles.
https://reviewboard.mozilla.org/r/99972/#review100686
Looks good, thanks!
Attachment #8820471 -
Flags: review?(jaws) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/149dc8ed363f
Remove colon from end of section titles. r=jaws
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → leftysolara
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•8 years ago
|
QA Whiteboard: [good first verify]
Comment 8•8 years ago
|
||
I have reproduced this bug with Nightly 53.0a1 (2016-12-16) (64-bit) on WIndows 7,64 Bit!
This bug's fix is verified with latest Beta!
Build ID : 20170313154936
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
[testday-20170317]
Comment 9•8 years ago
|
||
Verified fixed also on Ubuntu 14.04 x64 and Mac OS X 10.11 using Firefox 53 Beta 7.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•