Jared Wein [:jaws] (please needinfo? me) Reporter
	Description • 8 years ago

See slides 27 and 28 of https://bugzilla.mozilla.org/attachment.cgi?id=8819509

	Jared Wein [:jaws] (please needinfo? me) Reporter
	Comment 1 • 8 years ago

Hey Jalen, would you like to work on this bug next? See the Updates section on the Advanced page of the Preferences. The section titles shouldn't have colons at the end.

You can read https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings and other parts of that page to learn more about how localization (user-facing strings) are used in Firefox.

Since the meaning of the strings aren't changing (just removing the colon), I don't think we need to update the entity's key. Flod, can you confirm?

	Francesco Lodolo [:flod]
	Comment 2 • 8 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Since the meaning of the strings aren't changing (just removing the colon),
> I don't think we need to update the entity's key. Flod, can you confirm?

In this case I would use a new string ID, mostly to make sure all locales notice the change, and adopt the same consistency en-US is trying to get.

Talking about those slides, I would point out that I don't see a "DRM content" on OS X, but I see a "Automatically update:" with a colon.

	Jalen Adams Assignee
	Comment 3 • 8 years ago

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> Hey Jalen, would you like to work on this bug next? See the Updates section
> on the Advanced page of the Preferences. The section titles shouldn't have
> colons at the end.
> 
> You can read
> https://developer.mozilla.org/en-US/docs/Mozilla/Localization/
> Localization_content_best_practices#Changing_existing_strings and other
> parts of that page to learn more about how localization (user-facing
> strings) are used in Firefox.
> 
> Since the meaning of the strings aren't changing (just removing the colon),
> I don't think we need to update the entity's key. Flod, can you confirm?

Sure. I'll get on this as soon as I can.

	Jared Wein [:jaws] (please needinfo? me) Reporter
	Comment 5 • 8 years ago
mozreview-review

Comment on attachment 8820471 [details]
Bug 1324173 - Remove colon from end of section titles.

https://reviewboard.mozilla.org/r/99972/#review100686

Looks good, thanks!

	Pulsebot
	Comment 6 • 8 years ago

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/149dc8ed363f
Remove colon from end of section titles. r=jaws

	Carsten Book [:Tomcat]
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/149dc8ed363f

	Mohammad Maruf Rahman
	Comment 8 • 8 years ago

I have reproduced this bug with Nightly 53.0a1 (2016-12-16) (64-bit) on WIndows 7,64 Bit!

This bug's fix is verified with latest Beta!

Build ID   : 20170313154936
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0

[testday-20170317]

	Camelia Badau [:cbadau], Desktop QA
	Comment 9 • 8 years ago

Verified fixed also on Ubuntu 14.04 x64 and Mac OS X 10.11 using Firefox 53 Beta 7.