Closed Bug 1324246 Opened 8 years ago Closed 7 years ago

Do not percent encode single quotes in queries to match the spec

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: manishearth, Assigned: valentin)

References

Details

(Whiteboard: [necko-next])

Attachments

(1 file)

Stop encoding the apostrophe in all parts of the URI
(deleted), patch
mcmanus
: review-
manishearth
: feedback+
Details | Diff | Splinter Review
We currently percent encode the single quote in URLs like `"http://foo.bar?\'"`. Spec says we shouldn't. Current behavior matches chrome but not other browsers (https://github.com/whatwg/url/issues/172) https://url.spec.whatwg.org/#default-encode-set
Assignee: nobody → valentin.gosu
Whiteboard: [necko-active]
According to the URL spec, the apostrophe is a URL code point, and as such does not need to be escaped. In order to ensure that our new behaviour converges with rust-url, I also changed the rusturl test to check for the same result. MozReview-Commit-ID: Gvn8nUzotwU
Attachment #8822666 - Flags: review?(mcmanus)
Comment on attachment 8822666 [details] [diff] [review] Stop encoding the apostrophe in all parts of the URI Review of attachment 8822666 [details] [diff] [review]: ----------------------------------------------------------------- This should make a couple of WPT tests pass too.
Attachment #8822666 - Flags: feedback+
Comment on attachment 8822666 [details] [diff] [review] Stop encoding the apostrophe in all parts of the URI Review of attachment 8822666 [details] [diff] [review]: ----------------------------------------------------------------- work with chrome to have their behavior changed first.
Attachment #8822666 - Flags: review?(mcmanus) → review-
Whiteboard: [necko-active] → [necko-next]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P2
Closing as WONTFIX per https://github.com/whatwg/url/issues/348
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: