Closed Bug 1324328 Opened 8 years ago Closed 8 years ago

Remove MozChecker and some unused code

Categories

(Developer Infrastructure :: Source Code Analysis, defect)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Remove MozChecker and some unused code
(deleted), patch
nika
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #8819711 - Flags: review?(michael)
Blocks: 1324315
Assignee: nobody → ehsan
Comment on attachment 8819711 [details] [diff] [review] Remove MozChecker and some unused code Review of attachment 8819711 [details] [diff] [review]: ----------------------------------------------------------------- \o/ ::: build/clang-plugin/Utils.h @@ +348,5 @@ > CXXRecordDecl *Clazz = T->getAsCXXRecordDecl(); > return Clazz ? getBaseRefCntMember(Clazz) : 0; > } > > +inline bool hasCustomAnnotation(const Decl *D, const char *Spelling) { I feel like Spelling should be a StringRef here, but it probably doesn't matter.
Attachment #8819711 - Flags: review?(michael) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/20134b5c4194 Remove MozChecker and some unused code; r=mystor
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/79cdd0e0ee9b follow-up: Make hasCustomAnnotation's second argument a StringRef
https://hg.mozilla.org/mozilla-central/rev/20134b5c4194 https://hg.mozilla.org/mozilla-central/rev/79cdd0e0ee9b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: