###!!! ASSERTION: Need to flush before destroying!: 'mEntryList.empty()', file /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/OverflowChangedTracker.h, line 43 dom/plugins/test/crashtests/843086.xhtml layout/base/crashtests/931450.html layout/generic/crashtests/1054010-1.html layout/generic/crashtests/1146103.html layout/svg/crashtests/340945-1.svg

layout/generic/crashtests/1039454-1.html hits this assertion too, as well as: ###!!! ASSERTION: Wrong parent style context: 'Error', file /home/worker/workspace/build/src/layout/base/RestyleManagerBase.cpp, line 302

This is fixed in the latest mozilla-central -> stylo merge.

This didn't get fixed after all (see bug 1334938); sorry for the noise.

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7771169d9f8a stylo: Downgrade "Need to flush before destroying!" assertion since it occurs frequently. r=me

Backout by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/17074be26231 Backed out changeset 7771169d9f8a

Backed out for Windows build bustage. Please ignore the backouts of the other bugs which landed with this one, these got relanded. https://hg.mozilla.org/integration/mozilla-inbound/rev/17074be2623163a700e69959654b052c33f0c8c2 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e3687105be00ff3532b62c26c5d38a92f795f441 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=73278465&repo=mozilla-inbound 08:23:35 INFO - #line 30 "c:/builds/moz2_slave/m-in-w32-000000000000000000000/build/src/obj-firefox/layout/mathml/Unified_cpp_layout_mathml1.cpp" 08:23:35 INFO - Unified_cpp_layout_mathml1.cpp 08:23:35 INFO - c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\obj-firefox\dist\include\mozilla/OverflowChangedTracker.h(44): error C2220: warning treated as error - no 'object' file generated 08:23:35 INFO - Warning: C4003 in c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\obj-firefox\dist\include\mozilla\OverflowChangedTracker.h: not enough actual parameters for macro 'NS_ASSERTION' 08:23:35 INFO - c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\obj-firefox\dist\include\mozilla/OverflowChangedTracker.h(44): warning C4003: not enough actual parameters for macro 'NS_ASSERTION'

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dca29e340ecc stylo: Downgrade "Need to flush before destroying!" assertion since it occurs frequently. r=me

layout/style/test/test_bug732209.html layout/style/test/test_change_hint_optimizations.html layout/style/test/test_computed_style.html layout/style/test/test_media_queries.html layout/style/test/test_rule_serialization.html

We're just forgetting to flush the overflow changed tracker, which is what was causing the assertions I was seeing at bug 1350140. The last patch over there should fix this too.

Given comment 11, probably we may be able to upgrade this assertion back and close this bug?

Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0aab3b86d961 Upgrade back "Need to flush before destroying!" assertion.