Closed
Bug 1324693
Opened 8 years ago
Closed 8 years ago
stylo: several tests non-fatally assert with a few animation related assertions
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: heycam, Assigned: boris)
References
(Blocks 1 open bug)
Details
Attachments
(2 obsolete files)
###!!! ASSERTION: stylo: Servo-backed style system should not be using EffectCompositor: 'Error', file /home/worker/workspace/build/src/dom/animation/EffectCompositor.cpp, line 279
###!!! ASSERTION: stylo: ServoRestyleManager does not support animations yet: 'Error', file /home/worker/workspace/build/src/layout/generic/nsFrame.cpp, line 710
###!!! ASSERTION: stylo: cannot handle compositor-driven animations yet: 'Error', file /home/worker/workspace/build/src/dom/animation/EffectCompositor.cpp, line 153
dom/animation/test/crashtests/1216842-5.html
dom/animation/test/crashtests/1216842-6.html
dom/animation/test/crashtests/1272475-1.html
dom/animation/test/crashtests/1272475-2.html
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → boris.chiou
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•8 years ago
|
Status: ASSIGNED → NEW
|
|
Assignee | |
Updated•8 years ago
|
|
||
Updated•8 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•8 years ago
|
||
Wrong bug number....
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8851505 -
Attachment is obsolete: true
Attachment #8851505 -
Flags: review?(emilio+bugs)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8851506 -
Attachment is obsolete: true
Attachment #8851506 -
Flags: review?(cam)
|
Reporter | |
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8851505 [details]
Bug 1324693 - Make parse_dimension() return a finite value.
https://reviewboard.mozilla.org/r/123820/#review126220
::: servo/components/style/values/specified/mod.rs:221
(Diff revision 1)
> }
> _ => Err(())
> }
> }
>
> #[allow(missing_docs)]
I don't think you need this on a non-pub fn.
|
|
Assignee | |
Comment 5•8 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #4)
> Comment on attachment 8851505 [details]
> Bug 1324693 - Make parse_dimension() return a finite value.
>
> https://reviewboard.mozilla.org/r/123820/#review126220
>
> ::: servo/components/style/values/specified/mod.rs:221
> (Diff revision 1)
> > }
> > _ => Err(())
> > }
> > }
> >
> > #[allow(missing_docs)]
>
> I don't think you need this on a non-pub fn.
OK. I would like to move these patches into another bug, and I will remove this non-pub fn.
|
||
Comment 6•8 years ago
|
||
Fixed by bug 1336769.
|
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•