Closed
Bug 1324911
Opened 8 years ago
Closed 8 years ago
Enable Linux Talos via BBB on trunk branches
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla53
People
(Reporter: garndt, Assigned: wcosta)
References
Details
Attachments
(1 file)
After Talos via BBB is greened up on Try, they should be enabled on trunk branches and the buildbot scheduler for those tasks disabled.
These branches include:
mozilla-inbound,autoland,mozilla-central, and graphics branches
Reporter | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
:Tomcat, :Callek, do you know which branches talos should not apply?
Flags: needinfo?(cbook)
Flags: needinfo?(bugspam.Callek)
Comment 2•8 years ago
|
||
(In reply to Wander Lairson Costa [:wcosta] from comment #1)
> :Tomcat, :Callek, do you know which branches talos should not apply?
i don't know but joel might know :)
Flags: needinfo?(cbook) → needinfo?(jmaher)
Comment 3•8 years ago
|
||
we run talos on mozilla-beta, mozilla-aurora, mozilla-central, mozilla-inbound, autoland, graphics, and Try.
I guess it is also run on Date, but I am not aware of data coming from date, although I see 1 job and only 1 job running on date- I would rather avoid Date.
Flags: needinfo?(jmaher)
Comment 4•8 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #3)
> we run talos on mozilla-beta, mozilla-aurora, mozilla-central,
> mozilla-inbound, autoland, graphics, and Try.
>
> I guess it is also run on Date, but I am not aware of data coming from date,
> although I see 1 job and only 1 job running on date- I would rather avoid
> Date.
This is all correct. As someone shepperding the `date` branch, we don't actually need Talos there.
HOWEVER, I would advocate for the following:
* Configure (in buildbot) builders for all supported talos types on every branch we have in buildbot.
* Don't *schedule* talos for these platforms on certain branches based on gecko version (e.g. not on 53 based branches)
This allows us to fully utilize taskcluster scheduling for talos, even on a project branch where we may not need talos today. And allows the Talos scheduling to be in-tree specified (e.g. `["integration", "release", "try", "graphics"]` as a run_on_projects, maybe). Without needing to reconfig buildbot, and without having issues where someone may add talos to a supported branch and end up breaking things because BB doesn't have a builder by the name being used.
Flags: needinfo?(bugspam.Callek)
Comment 5•8 years ago
|
||
I think that is a great idea to have all jobs we schedule via BBB fully available on all branches.
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #4)
> (In reply to Joel Maher ( :jmaher) from comment #3)
> > we run talos on mozilla-beta, mozilla-aurora, mozilla-central,
> > mozilla-inbound, autoland, graphics, and Try.
> >
> > I guess it is also run on Date, but I am not aware of data coming from date,
> > although I see 1 job and only 1 job running on date- I would rather avoid
> > Date.
>
> This is all correct. As someone shepperding the `date` branch, we don't
> actually need Talos there.
>
> HOWEVER, I would advocate for the following:
> * Configure (in buildbot) builders for all supported talos types on every
> branch we have in buildbot.
> * Don't *schedule* talos for these platforms on certain branches based on
> gecko version (e.g. not on 53 based branches)
>
Which platforms?
> This allows us to fully utilize taskcluster scheduling for talos, even on a
> project branch where we may not need talos today. And allows the Talos
> scheduling to be in-tree specified (e.g. `["integration", "release", "try",
> "graphics"]` as a run_on_projects, maybe). Without needing to reconfig
> buildbot, and without having issues where someone may add talos to a
> supported branch and end up breaking things because BB doesn't have a
> builder by the name being used.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8822431 [details]
Bug 1324911: Enable BBB talos jobs in all relevant branches.
https://reviewboard.mozilla.org/r/101346/#review101838
::: taskcluster/ci/test/tests.yml:907
(Diff revision 2)
> talos-chrome:
> description: "Talos chrome"
> suite: talos
> talos-try-name: chromez
> treeherder-symbol: tc-T(c)
> - run-on-projects: []
> + run-on-projects: ['mozilla-beta', 'mozilla-aurora', 'mozilla-central', 'mozilla-inbound', 'autoland', 'graphics', 'try']
what about `mozilla-release`?
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8822431 [details]
Bug 1324911: Enable BBB talos jobs in all relevant branches.
https://reviewboard.mozilla.org/r/101346/#review101858
I would like to ensure that when pushing to try we do not schedule talos with -u, but it is only scheduled with -t. On top of that, I want to make sure the try syntax is good, for example from trychooser, I made this:
try: -b o -p linux -u none -t tp5o
also we need to coordinate landing of this with disabling on branches. I assume we will be disabling talos on mozilla-beta/mozilla-aurora/trunk* - will we be shipping linux64 taskcluster builds from those branches? I only want branches that are shipping taskcluster builds to be running this via taskcluster.
Attachment #8822431 -
Flags: review?(jmaher) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 12•8 years ago
|
||
As we talked in irc, we are postponing release branches for later.
Assignee | ||
Comment 13•8 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #10)
> Comment on attachment 8822431 [details]
> Bug 1324911: Enable BBB talos jobs in all relevant branches.
>
> https://reviewboard.mozilla.org/r/101346/#review101858
>
> I would like to ensure that when pushing to try we do not schedule talos
> with -u, but it is only scheduled with -t. On top of that, I want to make
> sure the try syntax is good, for example from trychooser, I made this:
> try: -b o -p linux -u none -t tp5o
afaik, we can't schedule talos with -u
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → wcosta
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8822431 [details]
Bug 1324911: Enable BBB talos jobs in all relevant branches.
https://reviewboard.mozilla.org/r/101346/#review102046
looking over the updates here, this is what we want.
Assignee | ||
Comment 17•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8822431 [details]
Bug 1324911: Enable BBB talos jobs in all relevant branches.
https://reviewboard.mozilla.org/r/101346/#review101838
> what about `mozilla-release`?
As we talked in irc, mozilla-release doesn't run talos
Comment 18•8 years ago
|
||
we do not run talos on:
* linux32
* android
* mozilla-release
* mozilla-esr
* many other project branches
Comment 19•8 years ago
|
||
Pushed by wcosta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6ee758f7508
Enable BBB talos jobs in all relevant branches. r=jmaher
Comment 20•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•