STR: 1. Set about:config pref security.insecure_field_warning.contextual.enabled to 'true' 2. Visit http://www.stealmylogin.com/demo.html and click in the "username" field. 3. Hover the notification about the insecure form. ACTUAL RESULTS: When hovered (and then continuously after it's been hovered), the text changes to be white on a light-grey background. This makes it unreadable. EXPECTED RESULTS: Readable text, regardless of hover state. I'm using the default desktop theme, with Ubuntu 16.04.1 (LTS), with a fresh browser profile (using latest Firefox Nightly 53.0a1 2016-12-19). I haven't noticed this particular paint-point in other parts of the Firefox UI -- I think this is specific to this dialog. (Though maybe it's a general problem with this sort of dialog and we just don't have many of them?)

(Sorry, disregard comment 3. The renderings in 16.04 and 16.10 are actually equally-bad. I thought there was a difference, but it turns out it's just monitor color-profile differences between the two machines that I'm testing.)

[Tracking Requested - why for this release]: user-facing UI issue in a new feature

For comparison, here's what the autocomplete dropdown looks like, with this "contextual.enabled" pref disabled. As in the "bug" screencast, the text changes to white when hovered -- but the background also changes to orange.

Summing up: - it looks like this new UI is trying to be consistent with the appearance of our normal autocomplete dropdowns (and our dropdowns everywhere else in the UI -- e.g. searchbox, awesomebar, <select>, etc). - BUT we're missing the hovered background-color style right now -- the background color isn't changing on hover (though the foreground color is). - ...which means the text ends up unreadable when hovered. So we either need to add the missing background-color styling, OR alternately [if we're not striving for consistency] we need to get rid of the hover-triggered text-color change for this dropdown menu.

Tracking this new user-facing issue for 52

I can repro

Tested on: * Windows 10: default, High Contrast 1, & HC2 * OS X 10.12.1 * Ubuntu 16.04

Comment on attachment 8821664 [details] Bug 1324918 - Specify the selected insecure field warning color to ensure contrast with the background. https://reviewboard.mozilla.org/r/100870/#review101544 Looks good to me. Tested PASS on: * OS X 10.11.6 * Ubuntu 14.04 LTS: Ambiance(default), Radiance The background of contextual feedback is transparent on Ubuntu High Contrast theme, and the popup will cover the below content. I filed a new bug 1325869 to discuss the background issue.

Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/03dad9589751 Specify the selected insecure field warning color to ensure contrast with the background. r=seanlee

Comment on attachment 8821664 [details] Bug 1324918 - Specify the selected insecure field warning color to ensure contrast with the background. Approval Request Comment [Feature/Bug causing the regression]: bug 1319919 [User impact if declined]: Users won't be able to read the warning after it's enabled in bug 1217152 [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: No, but I could reproduce it and verified it during development. [Needs manual test from QE? If yes, steps to reproduce]: No, I don't think I made the problem worse and I'd like to have bug 1217152 landed ASAP for user testing to reduce risk for it. [List of other uplifts needed for the feature/fix]: bug 1217152 depends on this [Is the change risky?]: No [Why is the change risky/not risky?]: Simple change to use specific foreground and background colours together. [String changes made/needed]: None

Comment on attachment 8821664 [details] Bug 1324918 - Specify the selected insecure field warning color to ensure contrast with the background. fix color of insecure field warning, for aurora52

Tested on Ubuntu 16.04 with FF Nighlty 53.0a1(2017-01-13) and I can confirm the fix. I was able to reproduce this with the Nighlty version from description but after I update the version to 53.0a1(2017-01-13) I couldn't reproduce it any more.

Veified as fixed on Ubuntu 16.04 with FF Aurora 52.0a2(2017-01-23).