Closed Bug 1324920 Opened 8 years ago Closed 8 years ago

Update mozjs-sys vendored dependencies

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1324920 - Update mozjs_sys vendored crates.
(deleted), text/x-review-board-request
sfink
: review+
fitzgen
: review+
Details
'mach vendor rust' generates a big diff right now. Bump these deps to pick up recent bug fixes.
Assignee: nobody → giles
Comment on attachment 8820429 [details] Bug 1324920 - Update mozjs_sys vendored crates. https://reviewboard.mozilla.org/r/99914/#review100434 I don't think you really need my review for this, but here, have a blind r+.
Attachment #8820429 - Flags: review?(sphink) → review+
(In reply to Ralph Giles (:rillian) needinfo me from comment #0) > 'mach vendor rust' generates a big diff right now. Bump these deps to pick > up recent bug fixes. Note that with the patch from bug 1324462 'mach vendor rust' will not generate a big diff. But in general yeah, I don't object to bumping the deps.
Attachment #8820429 - Flags: review?(ted)
Clearing r?ted. Per IRC, build-peer review isn't needed for third_party/rust updates. Just want to confirm the Windows 8 debug 'make check' failure was spurious before landing.
Pushed by rgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21ce95f1dfa8 Update mozjs_sys vendored crates. r=fitzgen,sfink
https://hg.mozilla.org/mozilla-central/rev/21ce95f1dfa8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Shoot, wrong bug number - sorry! I meant to put that patch on bug 1336549.
Attachment #8833489 - Attachment is obsolete: true
Attachment #8833489 - Flags: review?(nfitzgerald)
Attachment #8833489 - Flags: review?(giles)
Comment on attachment 8833489 [details] Bug 1324920 - Update third-party vendored crates required by mozjs_sys. https://reviewboard.mozilla.org/r/109734/#review110790 ::: third_party/rust/libz-sys/Cargo.toml:14 (Diff revision 1) > repository = "https://github.com/alexcrichton/libz-sys" > -documentation = "http://alexcrichton.com/libz-sys" > +documentation = "https://docs.rs/libz-sys" > description = """ > Bindings to the system libz library (also known as zlib). > """ > +categories = ["external-ffi-bindings"] Cargo 0.16 still warns about this key, but I expect it will eventually go away, so I'm willing to live with them for now.
Attachment #8833489 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: