Open
Bug 1324935
Opened 8 years ago
Updated 2 years ago
Android UI MessageLoop and nsThread are not cleaned up on shutdown.
Categories
(GeckoView :: General, defect, P3)
GeckoView
General
Tracking
(firefox53 affected)
NEW
Tracking | Status | |
---|---|---|
firefox53 | --- | affected |
People
(Reporter: rbarker, Unassigned)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
The creation and destruction of the MessageLoop and nsThread for the Android UI thread are handled in nsAppShell. Unfortunately, currently in Fennec, the nsAppShell singleton appears to never get destroyed. This makes it impossible to test the Android UI thread clean up code which contains synchronous inter-thread code. If the nsAppShell is ever destroyed in future versions of Fennec or GeckoView, the Android UI thread clean up call should be enabled and tested.
Reporter | ||
Updated•8 years ago
|
Summary: Android UI MessageLoop and nsThread are no cleaned up on shutdown. → Android UI MessageLoop and nsThread are nor cleaned up on shutdown.
Reporter | ||
Updated•8 years ago
|
Summary: Android UI MessageLoop and nsThread are nor cleaned up on shutdown. → Android UI MessageLoop and nsThread are not cleaned up on shutdown.
Comment 1•8 years ago
|
||
I think nsAppShell gets destroyed (or should get destroyed) when we quit/restart Fennec through Gecko (e.g. using the QuitNow addon's "Quit" menu).
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Jim Chen [:jchen] [:darchons] from comment #1)
> I think nsAppShell gets destroyed (or should get destroyed) when we
> quit/restart Fennec through Gecko (e.g. using the QuitNow addon's "Quit"
> menu).
I actually tried using an add on called Quit Firefox (for mobile) and when I selected "Quit" from the menu, Fennec would quit but we would never return from MessageLoop::Run. It appeared we were just exiting. I'll try QuitNow and see if I get different results.
Reporter | ||
Comment 3•8 years ago
|
||
QuitNow seems to actually exit from MessageLoop::Run however the nsAppShell still does not appear to be destroyed.
Reporter | ||
Comment 4•8 years ago
|
||
After more investigation, it looks like something is reffing the nsAppShell and then not unreffing it so it does not get deleted. So shutdown appears to be working as expected, is just the nsAppShell that is not getting deleted.
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → rbarker
Reporter | ||
Comment 5•8 years ago
|
||
Priority: -- → P3
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Reporter | ||
Updated•5 years ago
|
Assignee: rbarker → nobody
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•