Closed Bug 1325303 Opened 8 years ago Closed 8 years ago

[AS] [Telemetry] Track position of Top Sites interactions in the extras

Categories

(Firefox for Android Graveyard :: General, defect, P1)

defect

Tracking

(firefox54 fixed)

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

(Whiteboard: [MobileAS])

Attachments

(3 files)

When user clicks on a highlight, we track its position and total amount of highlights displayed. We want to track position of a clicked top site as well. Total count is probably less useful here, as after some time it'll just converge on some query limit value. To do this, we'll need to re-shuffle some onClick handlers between TopSiteCard and TopSite*Adaptor classes, similar to how this is handled by highlights.
Iteration: 1.12 → ---
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Iteration: --- → 1.14
Priority: P2 → P1
Comment on attachment 8831048 [details] Bug 1325303 - A-S Telemetry: track positions of Top Site items for tile and menu interactions https://reviewboard.mozilla.org/r/107698/#review108976 ::: mobile/android/base/java/org/mozilla/gecko/home/activitystream/topsites/TopSitesPageAdapter.java:76 (Diff revision 1) > + final TopSite topSite = topSites.get(position); > + final int absolutePosition = getTopSiteAbsolutePosition(position); > + > + ActivityStreamTelemetry.Extras.Builder extras = ActivityStreamTelemetry.Extras.builder() > + .forTopSite(topSite) > + .set(ActivityStreamTelemetry.Contract.ACTION_POSITION, absolutePosition); Maybe the page number would be interesting too? For example item 5 can be on page 1 or page 2 and it could be interesting to know if people even swipe to see the next pages (like people tend to not go to the second page of search results).
Attachment #8831048 - Flags: review?(s.kaspari) → review+
Comment on attachment 8831049 [details] Bug 1325303 - A-S Telemetry: track position of highlights for menu interactions https://reviewboard.mozilla.org/r/107700/#review108978
Attachment #8831049 - Flags: review?(s.kaspari) → review+
Comment on attachment 8831050 [details] Bug 1325303 - Adjust A-S telemetry docs to reflect greater use of action_position https://reviewboard.mozilla.org/r/107702/#review108980
Attachment #8831050 - Flags: review?(s.kaspari) → review+
(In reply to Sebastian Kaspari (:sebastian) from comment #4) > Maybe the page number would be interesting too? For example item 5 can be on > page 1 or page 2 and it could be interesting to know if people even swipe to > see the next pages (like people tend to not go to the second page of search > results). That certainly seems useful as we start digging into how this new UI is used. Tracking page number explicitly is nice, less ambiguous - I'll add it in.
Pushed by gkruglov@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd240b4d35d8 A-S Telemetry: track positions of Top Site items for tile and menu interactions r=sebastian https://hg.mozilla.org/integration/autoland/rev/202a5b19143e A-S Telemetry: track position of highlights for menu interactions r=sebastian https://hg.mozilla.org/integration/autoland/rev/0b2b5e9cd091 Adjust A-S telemetry docs to reflect greater use of action_position r=sebastian
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: