Closed
Bug 1325478
Opened 8 years ago
Closed 7 years ago
Prune obsolete B2G components from Fennec's package manifest
Categories
(Firefox Build System :: General, defect, P3)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mds, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Some of the components in Fennec's package manifest are obsolete and not present anymore (see bug nukeb2g).
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
Does this allow to build with MOZ_PKG_FATAL_WARNINGS = 1 set in mobile/android/installer/Makefile.in?
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2)
> Does this allow to build with MOZ_PKG_FATAL_WARNINGS = 1 set in
> mobile/android/installer/Makefile.in?
Nope.
bin/libnssdbm3.so, bin/blocklist.xml and bin/components/components.manifest are still missing but not part of nukeb2g.
Reporter | ||
Updated•8 years ago
|
Summary: Prune obsolete components from Fennec's package manifest → Prune obsolete B2G components from Fennec's package manifest
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8821326 [details]
Bug 1325478 - Prune obsolete B2G components from Fennec's package manifest.
https://reviewboard.mozilla.org/r/100632/#review101694
As good as this looks, I'm not an expert on the Fennec code. I'm going to defer this review to Stefan.
::: mobile/android/installer/package-manifest.in:84
(Diff revision 1)
> @BINPATH@/classes.dex
>
> [browser]
> ; [Base Browser Files]
> @BINPATH@/application.ini
> -@BINPATH@/platform.ini
> + @BINPATH@/platform.ini
This whitespace change seems unwanted.
Attachment #8821326 -
Flags: review?(gps)
Updated•8 years ago
|
Attachment #8821326 -
Flags: review?(sarentz)
Comment hidden (mozreview-request) |
Updated•8 years ago
|
Attachment #8821326 -
Flags: review?(sarentz) → review?(s.kaspari)
Comment 7•8 years ago
|
||
Deflecting to Sebastian, who can find the right reviewer for this.
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8821326 [details]
Bug 1325478 - Prune obsolete B2G components from Fennec's package manifest.
https://reviewboard.mozilla.org/r/100632/#review112332
Attachment #8821326 -
Flags: review?(s.kaspari) → review+
Reporter | ||
Comment 10•7 years ago
|
||
(In reply to Mike Taylor [:miketaylr] (55 Regression Engineering Owner) from comment #9)
> Any reason we shouldn't land this?
Even though I have been out of the this loop for some time I don't think there's any real blocker on this.
The desktop manifest was updated long ago so my take is that - if releng is fine with this - we can definitely go ahead.:)
Flags: needinfo?(mdesimone)
Reporter | ||
Updated•7 years ago
|
Assignee: michel → nobody
Comment 11•7 years ago
|
||
I was just going through our bug backlog and it looks like the patch doesn't apply anymore and the older entries in the package manifest are removed.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•