Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me) Reporter
	Description • 8 years ago

In other words, get --enable-artifact-build-symbols working on Android. I'm filing this as a follow-up to https://bugzilla.mozilla.org/show_bug.cgi?id=1285608#c22

Without this, tests scheduled against an artifact build for Android _debug_ fail because they must find crashreporter-symbols in order to proceed. (Example:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=c40ef550e231bdaa2f8f936eca876e0adaf6291c&selectedJob=33339059)

Log excerpt from an Android debug artifact build with --enable-artifact-build-symbols:
 [task 2016-12-22T21:37:49.654957Z] 21:37:49     INFO -  Downloaded artifact to /home/worker/.mozbuild/package-frontend/0535b87f942e9a8a-public%2Fbuild%2Ftarget.crashreporter-symbols.zip

 [task 2016-12-22T21:37:49.655165Z] 21:37:49     INFO -  Installing from /home/worker/.mozbuild/package-frontend/0535b87f942e9a8a-public%2Fbuild%2Ftarget.crashreporter-symbols.zip

 [task 2016-12-22T21:37:49.655485Z] 21:37:49     INFO -  Processing contents of /home/worker/.mozbuild/package-frontend/0535b87f942e9a8a-public%2Fbuild%2Ftarget.crashreporter-symbols.zip

 [task 2016-12-22T21:37:49.655702Z] 21:37:49     INFO -  Writing processed /home/worker/.mozbuild/package-frontend/0535b87f942e9a8a-public%2Fbuild%2Ftarget.crashreporter-symbols.zip.processed.jar

 [task 2016-12-22T21:37:51.082487Z] 21:37:51     INFO -  Adding libomxplugin.so.sym to processed archive

 [task 2016-12-22T21:37:51.082676Z] 21:37:51     INFO -  Adding libnss3.so.sym to processed archive

 [task 2016-12-22T21:37:51.082937Z] 21:37:51     INFO -  Adding libplugin-container.so.sym to processed archive

 [task 2016-12-22T21:37:51.083222Z] 21:37:51     INFO -  Adding libxul.so.sym to processed archive

 [task 2016-12-22T21:37:51.083474Z] 21:37:51     INFO -  Adding libfakeopenh264.so.sym to processed archive

 [task 2016-12-22T21:37:51.083683Z] 21:37:51     INFO -  Adding libreplace_jemalloc.so.sym to processed archive

 [task 2016-12-22T21:37:51.083877Z] 21:37:51     INFO -  Adding libplugin-container-pie.so.sym to processed archive

 [task 2016-12-22T21:37:51.084116Z] 21:37:51     INFO -  Adding libreplace_malloc.so.sym to processed archive

 [task 2016-12-22T21:37:51.084319Z] 21:37:51     INFO -  Adding libomxpluginkk.so.sym to processed archive

 [task 2016-12-22T21:37:51.084505Z] 21:37:51     INFO -  Adding libclearkey.so.sym to processed archive

 [task 2016-12-22T21:37:51.084698Z] 21:37:51     INFO -  Adding libsoftokn3.so.sym to processed archive

 [task 2016-12-22T21:37:51.084898Z] 21:37:51     INFO -  Adding liblogalloc.so.sym to processed archive

 [task 2016-12-22T21:37:51.085080Z] 21:37:51     INFO -  Adding liblgpllibs.so.sym to processed archive

 [task 2016-12-22T21:37:51.085260Z] 21:37:51     INFO -  Adding libmozglue.so.sym to processed archive

 [task 2016-12-22T21:37:51.085440Z] 21:37:51     INFO -  Adding libfake.so.sym to processed archive

 [task 2016-12-22T21:37:51.085620Z] 21:37:51     INFO -  Adding libnssckbi.so.sym to processed archive

 [task 2016-12-22T21:37:51.085802Z] 21:37:51     INFO -  Adding libfreebl3.so.sym to processed archive

 [task 2016-12-22T21:37:51.111405Z] 21:37:51     INFO -  Installing from processed /home/worker/.mozbuild/package-frontend/0535b87f942e9a8a-public%2Fbuild%2Ftarget.crashreporter-symbols.zip.processed.jar

 [task 2016-12-22T21:37:51.114693Z] 21:37:51     INFO -  Error running mach:

 [task 2016-12-22T21:37:51.114873Z] 21:37:51     INFO -      ['--log-no-times', 'artifact', 'install']

 [task 2016-12-22T21:37:51.115089Z] 21:37:51     INFO -  The error occurred in code that was called by the mach command. This is either

 [task 2016-12-22T21:37:51.115284Z] 21:37:51     INFO -  a bug in the called code itself or in the way that mach is calling it.

 [task 2016-12-22T21:37:51.115563Z] 21:37:51     INFO -  You should consider filing a bug for this issue.

 [task 2016-12-22T21:37:51.115767Z] 21:37:51     INFO -  If filing a bug, please include the full output of mach, including this error

 [task 2016-12-22T21:37:51.115897Z] 21:37:51     INFO -  message.

 [task 2016-12-22T21:37:51.116126Z] 21:37:51     INFO -  The details of the failure are as follows:

 [task 2016-12-22T21:37:51.116339Z] 21:37:51     INFO -  OSError: [Errno 20] Not a directory: '/home/worker/workspace/build/src/obj-firefox/dist/bin/libomxplugin.so/2362AAA2CB94645099E02A2D5DC13A770'

 [task 2016-12-22T21:37:51.116495Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/mach_commands.py", line 1566, in artifact_install

 [task 2016-12-22T21:37:51.116650Z] 21:37:51     INFO -      return artifacts.install_from(source, self.distdir)

 [task 2016-12-22T21:37:51.116845Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/artifacts.py", line 1064, in install_from

 [task 2016-12-22T21:37:51.116961Z] 21:37:51     INFO -      return self.install_from_recent(distdir)

 [task 2016-12-22T21:37:51.117289Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/artifacts.py", line 1026, in install_from_recent

 [task 2016-12-22T21:37:51.117434Z] 21:37:51     INFO -      return self._install_from_hg_pushheads(hg_pushheads, distdir)

 [task 2016-12-22T21:37:51.117616Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/artifacts.py", line 1015, in _install_from_hg_pushheads

 [task 2016-12-22T21:37:51.118269Z] 21:37:51     INFO -      if self.install_from_url(url, distdir):

 [task 2016-12-22T21:37:51.118323Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/artifacts.py", line 993, in install_from_url

 [task 2016-12-22T21:37:51.118350Z] 21:37:51     INFO -      return self.install_from_file(filename, distdir)

 [task 2016-12-22T21:37:51.118389Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/artifacts.py", line 975, in install_from_file

 [task 2016-12-22T21:37:51.118510Z] 21:37:51     INFO -      file_existed, file_updated = fh.close()

 [task 2016-12-22T21:37:51.118708Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 263, in close

 [task 2016-12-22T21:37:51.118863Z] 21:37:51     INFO -      ensureParentDir(self.name)

 [task 2016-12-22T21:37:51.119092Z] 21:37:51     INFO -    File "/home/worker/workspace/build/src/python/mozbuild/mozbuild/util.py", line 154, in ensureParentDir

 [task 2016-12-22T21:37:51.119276Z] 21:37:51     INFO -      os.makedirs(d)

 [task 2016-12-22T21:37:51.119500Z] 21:37:51     INFO -    File "/usr/lib/python2.7/os.py", line 157, in makedirs

[task 2016-12-22T21:37:51.119675Z] 21:37:51 INFO - mkdir(name, mode)

	Chris Manchester (limited bugmail, email directly) Assignee
	Comment 1 • 8 years ago

These actually seem to work fine with "--enable-artifact-build-symbols" in the relevant mozconfigs in https://treeherder.mozilla.org/#/jobs?repo=try&revision=44c47330dd22a7a14f21cd901e4c0ce9cae08824

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023)
	Comment 3 • 8 years ago

(In reply to Chris Manchester (:chmanchester) from comment #1)
> These actually seem to work fine with "--enable-artifact-build-symbols" in
> the relevant mozconfigs in
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=44c47330dd22a7a14f21cd901e4c0ce9cae08824

This didn't used to work: see https://bugzilla.mozilla.org/show_bug.cgi?id=1285608#c22.  It appears to be working in your B jobs, which really do seem to be artifact builds, so that's good!

	Nick Alexander :nalexander [he/him] (PTO until Montreallhands August 21, 2023)
	Comment 4 • 8 years ago
mozreview-review

Comment on attachment 8835064 [details]
Bug 1325485 - Upload buildsymbols from android artifact builds in automation.

https://reviewboard.mozilla.org/r/110756/#review112164

If it works for you, it works for me!

See my comment in BZ -- I don't know _why_ this is working now.  That's on you to be happy with :)

	Pulsebot
	Comment 5 • 8 years ago

Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1266fe10e562
Upload buildsymbols from android artifact builds in automation. r=nalexander

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/1266fe10e562