Closed
Bug 1325685
Opened 8 years ago
Closed 8 years ago
WebGL conformance test conformance/textures/misc/cube-incomplete-fbo failure
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: kvark, Assigned: kvark)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jgilbert
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
I scanned the GL ES 3.0 specification and couldn't figure out why exactly the cube face being a framebuffer attachment has to require the whole cube texture to be complete.
Related Chromium issue - https://bugs.chromium.org/p/chromium/issues/detail?id=559362
Assignee | ||
Updated•8 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Comment 1•8 years ago
|
||
Also relevant discussion - https://bugs.chromium.org/p/chromium/issues/detail?id=528145
Basically, the spec is ambiguous, and WebGL2 follows the most conservative restrictions.
Assignee | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
I actually think the spec is not too ambiguous here. The spirit of the restriction seems clear, particularly with the OpenGL version of the restriction using a semi-colon for clarity.
Updated•8 years ago
|
Attachment #8822190 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 4•8 years ago
|
||
try results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a95e2f5726ec29ca8bd37264379ffc4130a6a361
Not sure if I need to change the mochitest-errata in a separate patch here?
Flags: needinfo?(jgilbert)
Keywords: checkin-needed
Comment 5•8 years ago
|
||
The Try push has test failures that need to be resolved before this can land.
https://treeherder.mozilla.org/logviewer.html#?job_id=67269869&repo=try
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
New try results are clean: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5af2e0ad099616f907190fcad18c66f0d282e6dd
I wish someone looks into my mochitest-errata changes though before merging.
Flags: needinfo?(jgilbert)
Keywords: checkin-needed
Assignee | ||
Comment 7•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8822190 -
Attachment is obsolete: true
Comment 8•8 years ago
|
||
Comment on attachment 8825459 [details] [diff] [review]
Ensure the cube attachment is complete.
Review of attachment 8825459 [details] [diff] [review]:
-----------------------------------------------------------------
When you upload a fix to an r+'d patch, set r+ on the new patch. (unless there's enough changes to warrant re-review) This helps our sheriffs know what/when they can land.
Attachment #8825459 -
Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/926cb3c2f79a
Ensure the cube attachment is complete. r=jgilbert
Keywords: checkin-needed
Comment 10•8 years ago
|
||
Comment on attachment 8825459 [details] [diff] [review]
Ensure the cube attachment is complete.
Approval Request Comment
[Feature/Bug causing the regression]: WebGL 2
[User impact if declined]: Possible behavior differences between os/driver/browsers.
[Is this code covered by automated tests?]: Yes, included here.
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Not risky.
[Why is the change risky/not risky?]: It's a very clear patch that touches little else.
[String changes made/needed]: none
Attachment #8825459 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox51:
--- → wontfix
status-firefox52:
--- → affected
Comment 11•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 12•8 years ago
|
||
Comment on attachment 8825459 [details] [diff] [review]
Ensure the cube attachment is complete.
webgl2 fix for aurora52
Attachment #8825459 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•8 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•