Closed Bug 1325686 Opened 8 years ago Closed 8 years ago

De-unify Interpreter.cpp

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file)

I was doing an incremental build for a small change, and I noticed that my compiler was working on Unified_cpp_js_src30.obj for a very very long time. I eventually assumed that I somehow hung my compiler, and I killed it. Later I realized that the cpp file I changed was unlucky enough to have been unified with the massively complex Interpreter.cpp. De-unifying Interpreter.cpp would: - Speed up recompile on the files currently unified with it - Make it more clear in Task Manager that the task is for Interpreter.obj and signal to me that I should wait longer before killing it
Attached patch deunify (deleted) — Splinter Review
Assignee: nobody → dmajor
Attachment #8821617 - Flags: review?(luke)
I approve of this change. Interpreter.cpp takes the longest to compile of any source file in the tree.
Comment on attachment 8821617 [details] [diff] [review] deunify Good observation, makes sense to me.
Attachment #8821617 - Flags: review?(luke) → review+
Perhaps the file should be renamed Intrapreter.cpp?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: