Steps to reproduce: 1. Install https://addons.mozilla.org/en-US/firefox/addon/disable-ctrl-q-and-cmd-q/ 2. Open a non-browser window, e.g. the bookmark manager or the global JS console. 3. Press Ctrl-Q Expected: - Browser does not quit. Actual: - Browser quits This issue is not specific to Ctrl-Q, if I use Ctrl-Shift-E instead and use a background page with a browser.commands.onCommand listener, then I also observe that the shortcut is only working in browser windows. In Chrome, the shortcut even works in non-browser windows such as the devtools. // manifest.json { "name": "Ctrl-E", "version": "1", "background": {"scripts":["background.js"]}, "manifest_version": 2, "commands": { "some shortcut<": { "suggested_key": { "default": "Ctrl+Shift+E" }, "description": "Some description" } } } // background.js chrome.commands.onCommand.addListener(d => console.log(d) );

Hey Rob! This has been added to the agenda for the May 9 WebExtensions API triage. Would you be able to join us? Wiki: https://wiki.mozilla.org/Add-ons/Contribute/Triage Agenda: https://docs.google.com/document/d/1q7UD3DxsT5z0lO3EbOyF9Iln32Wg_e9LYMdHZ80BEb4/edit#heading=h.nowgt2eodtsv

I can't make it to today's triage meeting unfortunately.

The ability to register a shortcut should include "browser", "all" or some identifier like "inspector", adding a new key to the manifest. That would cover this bug. Adding an identifier like that to a shortcut would also prevent registering a shortcut for "all" when it only has effect in the browser window. // manifest.json { "name": "Ctrl-E", "version": "1", "background": {"scripts":["background.js"]}, "manifest_version": 2, "commands": { "some shortcut<": { "suggested_key": { "default": "Ctrl+Shift+E" }, "description": "Some description", "windowtype": "browser" } } }

Sorry for the slow update. The verdict from the meeting was that this seems like a good idea and no-one raised any objections. Sounds like if this was implemented, bug 1362147 would also be fixed, so duping that to this.

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.