contextMenus.OnClickData should provide selector of the clicked element
Categories
(WebExtensions :: General, enhancement, P3)
Tracking
(firefox63 verified)
Tracking | Status | |
---|---|---|
firefox63 | --- | verified |
People
(Reporter: kernp25, Assigned: robwu, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, Whiteboard: [design-decision-approved][contextMenus] triaged)
Attachments
(8 files, 2 obsolete files)
(deleted),
patch
|
mixedpuppy
:
feedback+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
text/x-review-board-request
|
mixedpuppy
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
mixedpuppy
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
mixedpuppy
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
mixedpuppy
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
mixedpuppy
:
review+
|
Details |
(deleted),
image/gif
|
Details |
Updated•8 years ago
|
Updated•8 years ago
|
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Updated•8 years ago
|
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
Comment 10•8 years ago
|
||
Reporter | ||
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
Comment 13•8 years ago
|
||
Comment 14•8 years ago
|
||
Comment 15•8 years ago
|
||
Assignee | ||
Comment 16•8 years ago
|
||
Reporter | ||
Comment 17•8 years ago
|
||
Comment 18•8 years ago
|
||
Reporter | ||
Comment 19•8 years ago
|
||
Comment 20•8 years ago
|
||
Reporter | ||
Comment 22•7 years ago
|
||
Reporter | ||
Comment 23•7 years ago
|
||
Comment 24•7 years ago
|
||
Comment 25•7 years ago
|
||
Reporter | ||
Comment 26•7 years ago
|
||
Comment 27•7 years ago
|
||
Updated•7 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 35•6 years ago
|
||
mozreview-review |
Comment 36•6 years ago
|
||
mozreview-review |
Comment 37•6 years ago
|
||
mozreview-review |
Comment 38•6 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 43•6 years ago
|
||
mozreview-review |
Comment 44•6 years ago
|
||
mozreview-review |
Comment 45•6 years ago
|
||
mozreview-review |
Comment 46•6 years ago
|
||
mozreview-review |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 52•6 years ago
|
||
mozreview-review |
Comment 53•6 years ago
|
||
Comment 54•6 years ago
|
||
bugherder |
Comment 55•6 years ago
|
||
Reporter | ||
Comment 56•6 years ago
|
||
Reporter | ||
Comment 57•6 years ago
|
||
Assignee | ||
Comment 58•6 years ago
|
||
Reporter | ||
Comment 59•6 years ago
|
||
Comment 60•6 years ago
|
||
Assignee | ||
Comment 61•6 years ago
|
||
str |
Comment 62•6 years ago
|
||
Updated•6 years ago
|
Comment 63•6 years ago
|
||
Comment 64•6 years ago
|
||
Assignee | ||
Comment 65•6 years ago
|
||
Comment 66•6 years ago
|
||
Comment 67•5 years ago
|
||
(In reply to Rob Wu [:robwu] from comment #65)
(In reply to Irene Smith from comment #64)
A lot of the changes described in these comments were already done. I made sure that anything that was missed was also done.
- Use code formatting when referring to method names or properties (i.e.
info.targetElementId).
Made sure that code formatting was used appropriately in all changed documents.
- Emphasize that the targetElementId identifies an element in a different
document, and that menus.getTargetElement will only return that element if
called in the same context of the document, for example using content
scripts (as shown in the example). Calling the method in the wrong context
will be a very common mistake, and in comment 57 you can already see a user
who made that mistake.
Added a note stating that the context must be in the same context as the document containing the targeted element.
- Please include all information from comment 58.
done
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus
- Do not add "New in Firefox 63", version availability belongs to the compat
tables.
"New in Firefox 63" does not seem to exist in the document.
- When a developer reads the summary, they will not know what the method
does. The first sentence looks brief and great, but can you expand the
second sentence to explain, e.g. "[... targetElementId parameter] that
identifies the clicked element."Also, it would be helpful to know if any exceptions are raised in cases
where the id is no longer valid. Does it fail silently and return null or
undefined or does it raise an error?When the integer ID is invalid, null is returned.
The return value is described in the page for the method and I also included it in the release notes.
Description
•