Closed
Bug 1325816
Opened 8 years ago
Closed 8 years ago
"Change search settings" button appears in a new line instead of the same line as other search providers if DPI > 125%
Categories
(Firefox :: Address Bar, defect, P2)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
People
(Reporter: itiel_yn8, Unassigned)
References
Details
(Keywords: rtl, Whiteboard: [fxsearch])
Attachments
(3 files)
See attached screenshot.
It seems as if there's not enough room for the settings icon to appear on the left of the separator.
This issue possibly occurs only on RTL builds.
Comment 1•8 years ago
|
||
(In reply to ItielMaN from comment #0)
> This issue possibly occurs only on RTL builds.
Can you please attach the LTR equivalent to the RTL screenshot? Thanks.
(In reply to Tomer Cohen :tomer from comment #1)
> (In reply to ItielMaN from comment #0)
> > This issue possibly occurs only on RTL builds.
> Can you please attach the LTR equivalent to the RTL screenshot? Thanks.
Well what do you know. The same applies to LTR builds.
Attachment #8821808 -
Attachment description: Not enough room for the settings icon → Not enough room for the settings icon- on RTL builds
Summary: [RTL] "Change search settings" button appears in a new line instead of the same line as other search providers → "Change search settings" button appears in a new line instead of the same line as other search providers
Comment 3•8 years ago
|
||
Unable to reproduce on my machine. Could be a resolution issue?
Things just keep getting intereseting.
I'm running Windows 10 with 1920x1080 resolution, and 150% DPI scaling on a 24" monitor.
Changing the DPI to 125% or 100% fixes the issue.
So, this is a DPI-related issue.
See also bug 1206709.
Summary: "Change search settings" button appears in a new line instead of the same line as other search providers → "Change search settings" button appears in a new line instead of the same line as other search providers if DPI > 125%
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [fxsearch]
Comment 5•8 years ago
|
||
Bumping up the priority cause this also causes popup contents jumping (bug 1326235)
Priority: P3 → P2
Comment 6•8 years ago
|
||
[::mark] I'm able to reproduce and isn't only on LTR Builds but also when you copy and paste full URL to the awesome bar.
Steps to display issue:
1 Copy a full URL or a text and paste on the awesome bar.
2 Browser create 6 empty buttons "searchbar-engine-one-off-item dummy"
3 Settings buttons Goes in the wrong position
Steps to work normally:
1 start typing anything on the awesome bar
2 Browser create only 5 empty buttons "searchbar-engine-one-off-item dummy"
3 Settings goes in the right place
PS: I'm running my Nightly on Mac
[::mark] Maybe you could assign the bug to me, I'll try to fix it.
Comment 7•8 years ago
|
||
UPDATE: On my Mac this only happens because I've Test Pilot Tab Center active.
Fixed by bug 1316566.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 9•8 years ago
|
||
I tried to verify this, but I can't reproduce the initial issue.
ItielMaN, could you please confirm that this issue is fixed on your side?
Flags: needinfo?(itiel_yn8)
Reporter | ||
Comment 10•8 years ago
|
||
(In reply to Simona B [:simonab ] from comment #9)
> I tried to verify this, but I can't reproduce the initial issue.
>
> ItielMaN, could you please confirm that this issue is fixed on your side?
Yes it is.
Closing as VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Flags: needinfo?(itiel_yn8)
You need to log in
before you can comment on or make changes to this bug.
Description
•