Closed
Bug 1326058
Opened 8 years ago
Closed 8 years ago
icon and color are not in center of focus ring in container preferences dialog
Categories
(Firefox :: Settings UI, defect)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 53
Tracking | Status | |
---|---|---|
firefox53 | --- | verified |
People
(Reporter: aryx, Assigned: aryx)
References
(Blocks 1 open bug)
Details
(Whiteboard: [userContextId])
Attachments
(2 files)
Latest Nightly and Aurora (53.0a1 and 52.0a2) on Windows 8.1 64-bit
The icon and color are not in the center of the focus ring in the container preferences dialog.
Steps to reproduce:
1. Open about:config by typing in the location bar and press Enter.
2. Confirm the warning.
3. Search for privacy.userContext.ui.enabled and set it to true if it hasn't yet that value.
4. Search for privacy.userContext.enabled and set it to true if it hasn't yet that value.
5. Open the Preferences/Options, go to Privacy > Container Tabs (at the bottom) > Settings.
6. Click on the "Preferences" button of a container type.
Actual result:
Preferences open and icon and color are not in the center of the focus ring.
Expected:
Icon and color in center.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Blocks: ContextualIdentity
Whiteboard: [userContextId]
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8822200 [details]
Bug 1326058 - icon and color should be in center of focus ring in container preferences dialog.
https://reviewboard.mozilla.org/r/101182/#review101824
I'm wondering if all the selectors in this CSS file should have these id's on them or have another class like 'radio-buttons' for both radiogroups. Either way they probably should be consistent, currently we rely on just 'radio'.
Attachment #8822200 -
Flags: review?(jkt) → review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c62e38e79b7c
icon and color should be in center of focus ring in container preferences dialog. r=jkt
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment 5•8 years ago
|
||
I have reproduced this bug with Nightly 53.0a1 (2016-12-28) on Windows 8.1 , 64 Bit !
Build ID 20161228030213
User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
This bug's fix is Verified with latest Nightly !
Build ID 20161230030205
User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
[bugday-20161228]
Assignee | ||
Comment 6•8 years ago
|
||
Sorry, this bug isn't fixed in Nightly 20161230030205 because the change to the source code got added after the build started. The first Nightly with the fix should be 20161231.
Comment 7•8 years ago
|
||
Went through verification using the following build:
* fx53.0a1, buildid: 20170105030229, changeset: f13abb8ba9f3
Platforms Used:
* macOS 10.12.2 x64 - PASSED
* Windows 10 x64 VM - PASSED
* Windows 10 x64 Personal Desktop - PASSED
* Ubuntu 16.04.1 LTS VM - PASSED
Test Cases Used:
* ensured that the icons/colours under about:preferences#containers are correctly being centred when selected via:
** editing one of the four default containers
** creating a custom container
** editing a custom container
* ensured that the selected icons/colours are being used when editing/creating containers
Status: RESOLVED → VERIFIED
Has STR: --- → yes
OS: Unspecified → All
Hardware: Unspecified → All
You need to log in
before you can comment on or make changes to this bug.
Description
•