Closed
Bug 1326131
Opened 8 years ago
Closed 8 years ago
stylo: Handle CSS variables in AnimationValue
Categories
(Core :: CSS Parsing and Computation, defect, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: manishearth, Assigned: hiro)
References
Details
Attachments
(1 file)
Bug 1317208 adds `AnimationValue` to Servo but doesn't handle CSS variable values in the constructor from property declaration blocks. This should be fixed.
|
||
Comment 1•8 years ago
|
||
There are some wpt tests crashed because of this bug, I think.
error message:
0:08.94 PROCESS_OUTPUT: ProcessReader (pid:44792) "thread '<unnamed>' panicked at 'not yet implemented', [path to objdir]/toolkit/library/x86_64-apple-darwin/debug/build/style-ffe1341867262ac3/out/properties.rs:63850"
in properties.rs:
63847 PropertyDeclaration::Left(ref val) => {
63848 let computed = match *val {
63849 // https://bugzilla.mozilla.org/show_bug.cgi?id=1326131
63850 DeclaredValue::WithVariables(_) => unimplemented!(),
Crashed test files:
1. web-animations/interface/Animation/animate.html
2. web-animations/interface/KeyframeEffect/constructor.html
3. web-animations/interface/KeyframeEffect/setKeyframes.html
|
||
Updated•8 years ago
|
Priority: -- → P2
|
Assignee | |
Comment 2•8 years ago
|
||
Bug 1336668 is the bug that Gecko implemented css variable animations.
|
|
Assignee | |
Comment 3•8 years ago
|
||
I meant bug 1268858.
|
|
Assignee | |
Comment 4•8 years ago
|
||
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8854597 [details]
Bug 1326131 - Make AnimationValue::from_declaration return computed CSS variable.
https://reviewboard.mozilla.org/r/126554/#review129136
Attachment #8854597 -
Flags: review?(manishearth) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Thank you Manish!
https://github.com/servo/servo/pull/16263
|
|
Assignee | |
Comment 8•8 years ago
|
||
Assignee: nobody → hikezoe
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•