Some of the webdriver commands do not throw a UnsupportedOperationError exception in case the command gets issued in chrome context.

Comment on attachment 8822419 [details] Bug 1326174 - For unsupported commands in chrome context throw UnsupportedOperationError https://reviewboard.mozilla.org/r/101338/#review101902 ::: testing/marionette/assert.js:81 (Diff revision 2) > + * > + * @throws {UnsupportedOperationError} > + * If |context| is not content. > + */ > +assert.content = function (context, msg = "") { > + msg = msg || error.pprint`Expected ${context} to be content`; I wonder if this should simply say “Command not supported in chrome context” so we don’t have to override the message every time. I don’t think there is any value in saying which _specific_ command was not available. ::: testing/marionette/driver.js:2530 (Diff revision 2) > ]; > > let or = String(cmd.parameters.orientation); > assert.string(or); > let mozOr = or.toLowerCase(); > - if (!ors.include(mozOr)) { > + if (!ors.includes(mozOr)) { Well spotted.

Comment on attachment 8822419 [details] Bug 1326174 - For unsupported commands in chrome context throw UnsupportedOperationError https://reviewboard.mozilla.org/r/101338/#review101902 > I wonder if this should simply say “Command not supported in chrome context” so we don’t have to override the message every time. I don’t think there is any value in saying which _specific_ command was not available. That makes sense. I will correct it. > Well spotted. Well, it was hiding for Fennec until I landed my skip decorator fix earlier today. So I have seen it here: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=mn&bugfiler&filter-tier=1&filter-tier=2&filter-tier=3&selectedJob=65287721 I actually may want to split this out to a separate commit.

Comment on attachment 8822419 [details] Bug 1326174 - For unsupported commands in chrome context throw UnsupportedOperationError https://reviewboard.mozilla.org/r/101338/#review101902 > That makes sense. I will correct it. I assume you are fine if I also correct this for assert.[firefox,fennec,mobile].

(In reply to Henrik Skupin (:whimboo) from comment #5) > I assume you are fine if I also correct this for > assert.[firefox,fennec,mobile]. Can you please have a look again? Thanks.

r++

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57a62a57c996 For unsupported commands in chrome context throw UnsupportedOperationError r=ato

Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=65321739&repo=autoland https://hg.mozilla.org/integration/autoland/rev/976a2704406a

So the utils.py Puppeteer unit test indeed failed because it was using the delete_all_cookies() method in chrome scope. I fixed it locally and will push another try build.

Comment on attachment 8822532 [details] Bug 1326174 - Handle cookies with content scope in test_utils.py https://reviewboard.mozilla.org/r/101408/#review102038

Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cd1da60be54 Handle cookies with content scope in test_utils.py r=maja_zf https://hg.mozilla.org/integration/autoland/rev/3e78b4df8dd7 For unsupported commands in chrome context throw UnsupportedOperationError r=ato

https://hg.mozilla.org/mozilla-central/rev/2cd1da60be54 https://hg.mozilla.org/mozilla-central/rev/3e78b4df8dd7

Test-only patch which we need to uplift to aurora. Thanks.

the 2nd patch need rebasing for aurora

(In reply to Carsten Book [:Tomcat] from comment #18) > the 2nd patch need rebasing for aurora I pulled latest aurora code and tried to graft both commits which worked fine. Can you please check again what was wrong with your graft command?

https://hg.mozilla.org/releases/mozilla-aurora/rev/4dcafa858f95 https://hg.mozilla.org/releases/mozilla-aurora/rev/b910341ba56c