Closed
Bug 1326175
Opened 8 years ago
Closed 7 years ago
Stop preserving empty passwords in URLs
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: annevk, Assigned: valentin)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
Input: https://test:@test/ Expected output: https://test@test/ Actual output: https://test:@test/ Input https://:@test/ Expected output: https://test/ Actual output: Failure Tests: https://github.com/w3c/web-platform-tests/issues/4405 Standard: https://github.com/whatwg/url/pull/186
Updated•8 years ago
|
Assignee: nobody → valentin.gosu
Whiteboard: [necko-active]
Comment hidden (mozreview-request) |
Reporter | ||
Comment 2•7 years ago
|
||
Why add more mochitests? Are the web-platform-tests not sufficient? If so, why not add more tests there?
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Anne (:annevk) from comment #2) > Why add more mochitests? Are the web-platform-tests not sufficient? If so, > why not add more tests there? I added another xpcshell test because that tests the internal nsStandardURL implementation, while WPT tests the URL implementation. This is needed to test other code paths which may not be exposed to the web API such as nsIURI::SetUserPass
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8851540 [details] Bug 1326175 - Stop preserving empty passwords in URLs https://reviewboard.mozilla.org/r/123850/#review126286
Attachment #8851540 -
Flags: review?(mcmanus) → review+
Comment hidden (mozreview-request) |
Pushed by valentin.gosu@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4a00e1ca8f47 Stop preserving empty passwords in URLs r=mcmanus
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a00e1ca8f47
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•