Closed Bug 1326291 Opened 8 years ago Closed 8 years ago

[RTL] Align the domain name in the site info panel to the right

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 affected, firefox54 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Tracking Flags:
Tracking Status
firefox53 --- affected
firefox54 --- verified

People

(Reporter: itiel_yn8, Assigned: maliu)

References

Details

(Keywords: rtl)

Attachments

(3 files)

The panel on a New Tab
(deleted), image/png
Details
The panel on cdburnerxp.se
(deleted), image/png
Details
Bug 1326291 - Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL,
(deleted), text/x-review-board-request
sebastian
: review+
Details
Attached image The panel on a New Tab (deleted) —
To match the site info panel's UI, the domain name (including "Nightly" etc) should be aligned to the right in RTL builds. See attached screenshots of the panel's current look.
Attached image The panel on cdburnerxp.se (deleted) —
Max - can we have your input here?
status-firefox53: --- → affected
Flags: needinfo?(max)
OS: Unspecified → All
QA Contact: ioana.chiorean
Hardware: Unspecified → All
Version: unspecified → Trunk
I think the hostname should align with the favicon in RTL context. I'll take it from here.
Assignee: nobody → max
Flags: needinfo?(max)
Comment on attachment 8833157 [details] Bug 1326291 - Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL, https://reviewboard.mozilla.org/r/109384/#review110534
Attachment #8833157 - Flags: review?(s.kaspari) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f90b03778d1b Make width of SiteIdentity TextView as wrap_content to follow layout_gravity from layout_direction for RTL, r=sebastian
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f90b03778d1b
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
I can confirm this is fixed on latest Nightly.
Marking 54 as verified from the above comment.
status-firefox54: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: