Build errors like this: 12:07.02 z:/Mozilla/TB/dist/include\nsMsgMailNewsUrl.h(48): error C2144: syntax error: 'nsresult' should be preceded by ';' 12:07.02 z:/Mozilla/TB/dist/include\nsMsgMailNewsUrl.h(48): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C2059: syntax error: '(' 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C2059: syntax error: ')' 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C2143: syntax error: missing ')' before '->' 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C3613: missing return type after '->' ('int' assumed) 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C2143: syntax error: missing ';' before ')' 12:07.03 z:\mozilla\comm-central\mailnews\jsaccount\src\JaUrl.h(70): error C3551: if a trailing return type is used then the leading return type shall be the single type-specifier 'auto' (not 'int') Back out of bug 1323683 let's build properly.

This patch removes the nsIURIWithQuery and mJsIURIWithQuery but I still get this errors: 0:14.37 JaUrl.cpp 0:14.37 z:/Mozilla/TB/dist/include\nsMsgMailNewsUrl.h(48): error C2144: syntax error: 'nsresult' should be preceded by ';' 0:14.38 z:/Mozilla/TB/dist/include\nsMsgMailNewsUrl.h(48): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int My C++ knowledge is like zero and I don't know how this errors could be resolved.

Remove NS_DECL_NSIURIWITHQUERY from /mailnews/base/util/nsMsgMailNewsUrl.h Then you get a link error because the methods must be implemented. >> My C++ knowledge is like zero and I don't know how this errors could be resolved. Me too :)

Sorry, out for dinner, I'll fix it tonight. Compiling but not linking is already a step forward ;-)

This one also links and didn't crash SeaMonkey.

Comment on attachment 8822733 [details] [diff] [review] 1326433-wip2.patch Review of attachment 8822733 [details] [diff] [review]: ----------------------------------------------------------------- Please supply a commit message: Bug 1326433 - Port bug 1323683 to mailnews: Remove nsIURIWithQuery and implement {Get|Set}FilePath and {Get|Set}Query. r=jorgk I assume the implemented methods were the ones that prevented linking.

Comment on attachment 8822717 [details] [diff] [review] WIP patch Thanks, nice start!

>> I assume the implemented methods were the ones that prevented linking. Yes. Are the added attributes from netwerk/base/nsIURI.idl. >> Please supply a commit message You sure this is ok so? FRG

Basically the WIP2 fix but I move some methods a little higher. Please check if none of them really needs an own implementation in mailnews.

Additional whitespace fixes on top of the patch. Removed trailing blanks and tabs.

Comment on attachment 8822758 [details] [diff] [review] 1326433-nsIURIWithQuery.patch These need to be defined in the base classes as you have done, see for example: https://dxr.mozilla.org/comm-central/search?q=etHostAndPort&redirect=false void setHostAndPort(in AUTF8String hostport); is defined in nsIURI.idl and implemented in all the base classes. The methods you're adding are already in nsMsgMailNewsUrl: nsMsgMailNewsUrl.cpp#607 and further down.

Comment on attachment 8822759 [details] [diff] [review] 1326433-whitespace-fix.patch Review of attachment 8822759 [details] [diff] [review]: ----------------------------------------------------------------- I'm not keep on those white-space changes since they will make uplifts harder. TB 55+ would be a better time for a clean-up since less uplift-prone. Anyway, if you want to go ahead, you have my blessing ;-) r=jorgk.

s/keep/keen/

> These need to be defined in the base classes as you have done, Yes I saw but I was uneasy. But if there were needed in the first place they whould have probably already been implemented for nsIURIWithQuery in mailnews. I assumed CLOSED tree to actually fix the closed tree:) https://hg.mozilla.org/comm-central/rev/f7bc43a2fcccb6c5c4e8cd74221ee79c82c71664 https://hg.mozilla.org/comm-central/rev/e84176264e2b82b8eb362ff63e879537be53e4b7 > I'm not keep on those white-space changes since they will make uplifts harder. I know but trailing blanks are such a nuisance...