arni2033 Reporter
	Description • 8 years ago

>>>   My Info:   Win7_64, Nightly 52, 32bit, ID 20161001030430 (2016-10-01)
STR_1:
0. Set dark devtools theme, which is set by default on Firefox Developer Edition
1. Open url  data:text/html,<img src="z" width="200" height="200">
2. Open inspector, hover mouse over "z" in markup

AR:  Text in tooltip is black on black
ER:  The text should be readable

This is regression from bug 1266450. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=63ec66da50faad032454a44d3af3124c35102b3e&tochange=62ad4f6b5c3428e4b33e1e4ba75288c94c45ec92

	Julian Descottes [:jdescottes] Assignee
	Comment 1 • 8 years ago

Corrected STRs:

- set dark theme
- open data:text/html,<img src="http://a.b/c.jpg" width="200" height="200">

(with original STRs, I just get a 200x200 empty tooltip, which might be another bug)

	Gabriel [:gl] (ΦωΦ)
	Comment 3 • 8 years ago
mozreview-review

Comment on attachment 8825783 [details]
Bug 1326875 - fix font color for broken image tooltip in dark theme;

https://reviewboard.mozilla.org/r/103864/#review104690

Looks good!

::: devtools/client/themes/tooltips.css:456
(Diff revision 1)
> +
> +.devtools-tooltip-image-broken {
> +  box-sizing: border-box;
> +  height: 100%;
> +  text-align: center;
> +  line-height: 30px;`;

Remove `

	Julian Descottes [:jdescottes] Assignee
	Comment 5 • 8 years ago
mozreview-review-reply

Comment on attachment 8825783 [details]
Bug 1326875 - fix font color for broken image tooltip in dark theme;

https://reviewboard.mozilla.org/r/103864/#review104690

Thanks for the review. Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6db1f94f19280762f3a44b3153193909f6a06948

	Julian Descottes [:jdescottes] Assignee
	Comment 7 • 8 years ago

Bad amend ... try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e9ebff413f4ad40a8ee2c445a90967104f80b8b

	Julian Descottes [:jdescottes] Assignee
	Comment 8 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6147dd18d4268ccacee696321aa60730a5f5c353

	Pulsebot
	Comment 9 • 8 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a4d1cdec9cc2
fix font color for broken image tooltip in dark theme;r=gl

	Carsten Book [:Tomcat]
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/a4d1cdec9cc2

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 7 years ago

Please request Aurora approval on this when you get a chance.

	Julian Descottes [:jdescottes] Assignee
	Comment 12 • 7 years ago

Comment on attachment 8825783 [details]
Bug 1326875 - fix font color for broken image tooltip in dark theme;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1266450
[User impact if declined]: a devtools popup has unreadable text in dark theme
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple js/css fix, added a classname to an element, moved some styles from js to css.
[String changes made/needed]: N/A

	Julien Cristau [:jcristau]
	Comment 13 • 7 years ago

Comment on attachment 8825783 [details]
Bug 1326875 - fix font color for broken image tooltip in dark theme;

devtools tooltip styling fix, aurora52+

	Ryan VanderMeulen [:RyanVM]
	Comment 14 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/b998b3f693e1

	Md. Majedul islam
	Comment 15 • 7 years ago

I have reproduced this bug with Nightly 52.0a1 (2016-10-01) Windows 10 , 64 Bit !


This bug's fix is verified with latest Beta & Aurora!

Beta:
Build   ID      20170130065342
User Agent      Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

Aurora:
Build   ID    	20170131004003
User Agent    	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0                                                

[bugday-20170201]

	Surentharan
	Comment 16 • 7 years ago

[bugday-20170215]