arni2033 Reporter
	Description • 8 years ago

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160526082509
STR_1:
1. Right-click Australis Menu button, click "Customize..."
2. Right-click selected tab, click menuitem "Move to new window"

AR:  Customize tab is closed in window from Step 1 and a blank page opened in a new window
ER:  Either X or Y
 X) Customize tab should be correctly moved to a new window
 Y) Menuitem "Move to new window" in Step 2 should be disabled

This is a regression. Nightly 43 (2015-09-01) is unaffected, Nightly 49 (2016-05-26) is affected

	Emil Pasca [:emilpasca]
	Comment 1 • 8 years ago

I have managed to reproduce this issue following the steps from STR_1, here are the results:

Narrowed inbound regression window from [f9e4a562, 1a1ec353] (3 revisions) to [f9e4a562, c34fe673] (2 revisions) (~1 steps left)
Oh noes, no (more) inbound revisions :(
Last good revision: f9e4a56281d86c553b8cedd9cb86025813946ec0
First bad revision: c34fe673bb97d511920d2986cb84057f62e0c4a0
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=f9e4a56281d86c553b8cedd9cb86025813946ec0&tochange=c34fe673bb97d511920d2986cb84057f62e0c4a0

Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1014185

	Justin Dolske [:Dolske]
	Comment 2 • 8 years ago

Dao: your fix apparently regressed this, anything you think needs to be fixed here?

Seems like an exceedingly minor issue otherwise, and not something to track.

	Mike de Boer [:mikedeboer]
	Comment 4 • 8 years ago

Comment on attachment 8825733 [details] [diff] [review]
disable menu item

Review of attachment 8825733 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: browser/base/content/browser.js
@@ +7783,5 @@
>      var menuItems = aPopupMenu.getElementsByAttribute("tbattr", "tabbrowser-multiple");
>      for (let menuItem of menuItems)
>        menuItem.disabled = disabled;
>  
> +    if (this.contextTab.getAttribute("customizemode") == "true") {

nits: I think `.hasAttribute("customizemode")` is enough to make this work and I think the dominant style for one-line conditional blocks in this file don't use curly braces.

	Pulsebot
	Comment 5 • 8 years ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4c502e38c7
Disable "Move to New Window" context menu item for the customize mode tab. r=mikedeboer

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/3e4c502e38c7

	Azmina
	Comment 7 • 8 years ago

I have reproduced this bug with Nightly 53.0a1 (2017-01-01) (32-bit) , Windows 8.1 (64-bit).

This bug's fix is verified on Latest Nightly 53.0a1.

Build ID : 20170112030301
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20170111]

	Mike de Boer [:mikedeboer]
	Comment 8 • 8 years ago

Thanks!