Closed Bug 1327899 Opened 8 years ago Closed 7 years ago

Tables in UI: column title is invisible if I drag that column

Categories

(Toolkit :: Themes, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59

People

(Reporter: arni2033, Assigned: Paenglab)

References

Details

(Whiteboard: fixed by bug 1413979, bug 1423453 )

Attachments

(1 file, 1 obsolete file)

>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160526082509 STR_1: 1. Open history (Ctrl+Shift+H) 2. Drag the last column to the left (without dropping), so that the last column wasn't hovered AR: The column title is invisible ER: Title should be visible Note: Also happens in preferences when viewing sertificates
No longer blocks: 1277113
Component: Untriaged → Themes
Product: Firefox → Toolkit
Attached patch 1327899.patch (obsolete) (deleted) — Splinter Review
This is on all platforms the case except on Windows Classic mode. On Linux the text is still readable but with a very low contrast. On Linux I set a darker or black text color. On Windows default themes I use Highlight text as an invert to the highlight background when hovering. For the in-content pages I define now also a color to not depend on OS theme colors. Here again black to have a slight difference to the normal #333 text color.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8823114 - Flags: review?(dao+bmo)
Dão, review ping.
Comment on attachment 8823114 [details] [diff] [review] 1327899.patch I suspect it was intentional that the dragged column header would get grayed out to set it back against the potential drag targets. I tested your patch on Linux and it does the opposite: it makes the dragged column header darker than the others, which doesn't make sense to me.
Attachment #8823114 - Flags: review?(dao+bmo) → review-
Attached patch 1327899.patch v2 (deleted) — Splinter Review
(In reply to Dão Gottwald [:dao] from comment #3) > Comment on attachment 8823114 [details] [diff] [review] > 1327899.patch > > I suspect it was intentional that the dragged column header would get grayed > out to set it back against the potential drag targets. I tested your patch > on Linux and it does the opposite: it makes the dragged column header darker > than the others, which doesn't make sense to me. On non-incontent columns without the patch the dragged column background is darker than the other. But the text in it is no more readable. My patch fixes on non-incontent columns only the text color to make it readable. For in-content columns I added now the darker background. If you want, I could change the text color for in-content dragged columns (--in-content-dragging-text) to white instead of black.
Attachment #8823114 - Attachment is obsolete: true
Attachment #8838473 - Flags: review?(dao+bmo)
(In reply to Richard Marti (:Paenglab) from comment #4) > On non-incontent columns without the patch the dragged column background is > darker than the other. That's not the case on Ubuntu at least.
(In reply to Dão Gottwald [:dao] from comment #5) > (In reply to Richard Marti (:Paenglab) from comment #4) > > On non-incontent columns without the patch the dragged column background is > > darker than the other. > > That's not the case on Ubuntu at least. For me with a theme using grey background on dragged columns the text becomes almost the same color as the background. When I remove all color definitions in tree.css, it works again with the dragged columns. I think this is a problem of -moz-appearance: treeheadercell; using the color from tree.css but not the background-color. Either it should use both or none of them. Without patch you should see in in-content pages what colors are defined in tree.css and then see the unreadable text. I could also remove all color definitions in tree.css and add them in in-content.
(In reply to Richard Marti (:Paenglab) from comment #6) > (In reply to Dão Gottwald [:dao] from comment #5) > > (In reply to Richard Marti (:Paenglab) from comment #4) > > > On non-incontent columns without the patch the dragged column background is > > > darker than the other. > > > > That's not the case on Ubuntu at least. > > For me with a theme using grey background on dragged columns the text > becomes almost the same color as the background. When I remove all color > definitions in tree.css, it works again with the dragged columns. I think > this is a problem of -moz-appearance: treeheadercell; using the color from > tree.css but not the background-color. Either it should use both or none of > them. I cleaned this up for Linux in bug 1413979.
Depends on: 1413979
Comment on attachment 8838473 [details] [diff] [review] 1327899.patch v2 Using ThreeDDarkShadow or black for treecol[dragging="true"] in tree.css still doesn't make sense to me.
Attachment #8838473 - Flags: review?(dao+bmo)
Depends on: 1423453
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: fixed by bug 1413979, bug 1423453
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: