Open Bug 1328014 Opened 8 years ago Updated 2 years ago

Option "Disable JavaScript" isn't forgotten if the toolbox is closed

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox50 wontfix, firefox51 wontfix, firefox52 fix-optional, firefox53 wontfix, firefox54 fix-optional)

Tracking Flags:
Tracking Status
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- fix-optional
firefox53 --- wontfix
firefox54 --- fix-optional

People

(Reporter: arni2033, Unassigned)

References

Details

(Keywords: regression)

>>> My Info: Win7_64, Nightly 49, 32bit, ID 20160526082509 STR_1: 1. Open url [1] in a new tab 2. Open devtools -> options, enable "Disable JavaScript" 3. Close devtools AR: JavaScript is disabled ER: JavaScript should be enabled > [1] data:text/html,<body id="B"><script>B.style.background='gray'</script> Note: 1) Because tooltip of "Disable JavaScript" checkbox says "If the tab or the toolbox is closed, then this setting will be forgotten" 2) Because that's how it worked initially, before the regression This is regression from bug 1161072. Regression range: > https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=35918b0441b4&tochange=4fb7ff694bf5@ Alexandre Poirot [:ochameau]: It seems that this is a regresion caused by your change. Please have a look.
No longer blocks: 1277113
Component: Untriaged → Developer Tools
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 I have tested this issue on Windows 10 x64 with the latest Firefox release (50.1.0) and the latest Nightly (53.0a1-20170103030204) and managed to reproduce it. When loading the url [1] in the browser and disabling JavaScript as specified in STR_1, if you close the tab and reload it, JavaScript remains disabled. The issue is reproducible on all the tested builds ( 24.0a1, 32.0a1, 49.0a1..), on builds earlier than 15.0a1, I haven't managed to test this, as the STR_1 aren't applicable, due to the fact that the feature is missing from the devtools.
(In reply to Emil Pasca [:emilpasca] from comment #1) > User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 > Firefox/53.0 > > I have tested this issue on Windows 10 x64 with the latest Firefox release > (50.1.0) and the latest Nightly (53.0a1-20170103030204) and managed to > reproduce it. > When loading the url [1] in the browser and disabling JavaScript as > specified in STR_1, if you close the tab and reload it, JavaScript remains > disabled. > The issue is reproducible on all the tested builds ( 24.0a1, 32.0a1, > 49.0a1..), on builds earlier than 15.0a1, I haven't managed to test this, as > the STR_1 aren't applicable, due to the fact that the feature is missing > from the devtools. Maybe this comment is for the similar bug 1328013, which is for closing the _tab_, not the _toolbox_?
Alex, it seems like we should either fix this or change the toolbox wording... In general, I think it's important for these toolbox switches to correctly deactivate after closing the toolbox. Perhaps we didn't hear about it since no one uses this switch much?
status-firefox50: --- → wontfix
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox53: --- → affected
Flags: needinfo?(poirot.alex)
Priority: -- → P2
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3) > Alex, it seems like we should either fix this or change the toolbox > wording... In general, I think it's important for these toolbox switches to > correctly deactivate after closing the toolbox. Hum. But would you expect the document to be automatically reloaded to re-enable the JS on toolbox close? Having a reload when you toggle the checkbox in the options panel is ok, but I'm not sure for toolbox close... The docshell attribute is correctly desactived on toolbox close, but you have to reload the document to see the difference. I looked at chrome and the "Disable javascript" checkbox doesn't reload the document... So when you toggle the checkbox again, the JS kicks in immediately without any reload. Everything would be easier if we did'nt had to reload to toggle the JS!
Flags: needinfo?(poirot.alex)
Too late for a fix for 53, as we are in the last week of the 53 beta cycle.
status-firefox53: affected → wontfix
Bug #919604 seems to describe the same issue, but it occurs by restarting Firefox. Part of the mentioned bugreport is fixed though: The "nojs"-checkbox now seems to be set correctly after restart
Looks like the dev tools team has this on their backlog. Dropping this from regression tracking.
status-firefox54: affected → fix-optional
Product: Firefox → DevTools
Priority: P2 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.