Tim Nguyen :ntim Reporter
	Description • 8 years ago

STR:
- Open a tab with toolbox closed
- Press Alt+Cmd+I (Mac) or Ctrl+Shift+I twice quickly.
- The toolbox stays in a broken state

	Tim Nguyen :ntim Reporter
	Comment 1 • 8 years ago

Greg, can you take a look please? Thanks!

	Greg Tatum [:gregtatum]
	Comment 2 • 8 years ago

Hmm... I can fix the error with the following patch, but I'm getting some test failures with unresolved promises. I believe these are due to the fact that there is still some running code, but the window objects of the panels are destroyed.

https://gist.github.com/gregtatum/ce9e990eb36f560da8f86ec2c62ddcec

	Brian Grinstead [:bgrins]
	Comment 3 • 8 years ago

[Tracking Requested - why for this release]: This can cause an unusable devtools toolbox

	Brian Grinstead [:bgrins]
	Comment 4 • 8 years ago

It seems like we shouldn't have to worry about this case where the toolbox has been deleted but the same instance is being reopened in the middle of deletion.  This can't be the only bug that happens due to this scenario.

Maybe it'd be easier to immediately delete the toolbox object from the this._toolboxes map when closing the toolbox [0] instead of waiting for the toolbox destroy event to fire before doing so [1]. This would ensure a new toolbox instance is created every time an open->close->reopen happens.

[0]: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/devtools.js#469
[1]: https://dxr.mozilla.org/mozilla-central/source/devtools/client/framework/devtools.js#437

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 5 • 8 years ago

Hmm, I feel like :ochameau tweaked this process recently...

	Marcia Knous [:marcia]
	Comment 6 • 8 years ago

Tracking 53+ for the reasoning in Comment 3.

	Alexandre Poirot [:ochameau]
	Comment 7 • 8 years ago

Yes, I fixed something somewhat similar but on toolbox object creation in bug 1319928.

	Alexandre Poirot [:ochameau]
	Comment 8 • 8 years ago

It may be the same bug than bug 1328004. There is a race in closeToolbox, very similar to the one in showToolbox addressed in bug 1319928.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 9 • 8 years ago

Hi Tim does this bug still happen for you?

	Tim Nguyen :ntim Reporter
	Comment 10 • 8 years ago

(In reply to David Bolter [:davidb] from comment #9)
> Hi Tim does this bug still happen for you?

Doesn't seem to be happening anymore.