Stephen A Pohl [:spohl] (OOO until 9/8) Assignee
	Description • 8 years ago

If a user sets custom shortcuts in system preferences, these will be displayed next to menu items. However, until bug 429824 is fixed, we fail to respect these custom shortcuts. We should avoid displaying custom shortcuts next to the menu items to maintain proper state.

	Stephen A Pohl [:spohl] (OOO until 9/8) Assignee
	Comment 2 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee828e9096c7dfce95dafddc9da6cff8b7348f34
Bug 1328604: Avoid displaying custom shortcuts on OSX until bug 429824 is fixed. r=mstange

	Phil Ringnalda (:philor)
	Comment 3 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ee828e9096c7

	Chris Peterson [:cpeterson]
	Comment 4 • 8 years ago

Stephen, I found this bug because my custom keyboard shortcut (CMD+SHIFT+, to open Nightly's "About Nightly" dialog to force a Nightly update) stopped working. But if I am reading bug 429824 correctly, my custom keyboard shortcut never should have worked?? Or is bug 429824 only about overriding a menu item's default keyboard shortcut with a custom one? My custom keyboard shortcut has worked at least since OS X 10.11 and probably earlier.

	Stephen A Pohl [:spohl] (OOO until 9/8) Assignee
	Comment 5 • 8 years ago

(In reply to Chris Peterson [:cpeterson] from comment #4)
> Stephen, I found this bug because my custom keyboard shortcut (CMD+SHIFT+,
> to open Nightly's "About Nightly" dialog to force a Nightly update) stopped
> working. But if I am reading bug 429824 correctly, my custom keyboard
> shortcut never should have worked?? Or is bug 429824 only about overriding a
> menu item's default keyboard shortcut with a custom one? My custom keyboard
> shortcut has worked at least since OS X 10.11 and probably earlier.

No, it should never have worked based on bug 429824 and my own testing. Keeping n-i to back this out later tonight. We need to investigate this further before we can reland, since there's obviously more going on than what we were aware of before.

	Stephen A Pohl [:spohl] (OOO until 9/8) Assignee
	Comment 6 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d7224996287e80d2fb78ba163fd97d006a83ee4
Backout ee828e9096c7 (bug 1328604) for causing some custom shortcuts to stop working on OSX. r=backout

	Phil Ringnalda (:philor)
	Comment 7 • 8 years ago
backout bugherder

https://hg.mozilla.org/mozilla-central/rev/0d7224996287

	Chris Peterson [:cpeterson]
	Comment 8 • 8 years ago

Now that this change has been backed out, my custom keyboard shortcut (CMD+SHIFT+, to open Nightly's "About Nightly" dialog) works again in Nightly 53 build 2017-01-16 on macOS 10.12.

	Stephen A Pohl [:spohl] (OOO until 9/8) Assignee
	Comment 9 • 7 years ago

After investigating and confirming with :cpeterson via IRC, the application menu correctly responds to custom shortcuts thanks to [1]. So although menu items in the regular menu bar do not yet respect custom shortcuts (bug 429824), we should not land this patch since that would also disable custom shortcut handling in the application menu (which imo would be worse than the current behavior).

[1] https://dxr.mozilla.org/mozilla-central/source/widget/cocoa/nsChildView.mm#5450