Closed Bug 1329139 Opened 8 years ago Closed 8 years ago

Disable event recording by default

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
3

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

(Whiteboard: [measurement:client])

Attachments

(1 file, 1 obsolete file)

Based on the event storage size discussions and follow-ups, we want to start out with all event recording being disabled by default. Addons will be able to override this (per category). We might change that behavior later once we know better which kind of events are critical for our metrics. We still need to reach out to make people aware of this change.
Assignee: nobody → gfritzsche
I already reached out on fhr-dev: https://mail.mozilla.org/pipermail/fhr-dev/2017-January/001106.html I also have meetings with the search & shield groups scheduled to sync up on this.
Points: --- → 3
Attached patch Default event recording to disabled (obsolete) (deleted) — Splinter Review
This defaults event recording to disabled and adds a function to selectively enable recording for events in specified categories.
Attachment #8825742 - Flags: review?(alessio.placitelli)
Comment on attachment 8825742 [details] [diff] [review] Default event recording to disabled Review of attachment 8825742 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me, there are just a couple of potential nits in the Events test file. ::: toolkit/components/telemetry/tests/unit/test_TelemetryEvents.js @@ +35,5 @@ > } > } > } > > +add_task(function* test_recording_state() { nit: do you think it's worth commenting that this should be the first test in the file? @@ +284,5 @@ > Assert.equal(events.length, 2, "Should have recorded 2 events."); > Assert.equal(events[0][4], value, "Should have recorded the right value."); > Assert.equal(events[1][5]["key1"], value, "Should have recorded the right extra value."); > }); > + nit: is this intentional? Odd, my local copy already has a blank line at the end while the one in the repo doesn't seem to have it.
Attachment #8825742 - Flags: review?(alessio.placitelli) → review+
Attachment #8825742 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: