Closed
Bug 1329144
Opened 8 years ago
Closed 8 years ago
Custom tabs: support custom action button
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox54 fixed)
VERIFIED
FIXED
Firefox 54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: jcheng, Assigned: walkingice)
References
Details
Attachments
(3 files)
as a 3rd party app developer, I want to be able to customize the action button when I make use of custom tabs
|
Reporter | |
Updated•8 years ago
|
Blocks: customtabs
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → walkingice0204
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833876 [details]
Bug 1329144 - Remove useless variable
https://reviewboard.mozilla.org/r/109986/#review111550
Attachment #8833876 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833877 [details]
Bug 1329144 - IntentUtil can extract ActionButton info from Intent
https://reviewboard.mozilla.org/r/109988/#review111552
Attachment #8833877 -
Flags: review?(s.kaspari) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8833878 [details]
Bug 1329144 - CustomTabsActivity supports ActionButton
https://reviewboard.mozilla.org/r/109990/#review111554
::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java:278
(Diff revision 1)
> + private void onActionButtonClicked() {
> + PendingIntent pendingIntent = IntentUtil.getActionButtonPendingIntent(getIntent());
> + try {
> + pendingIntent.send();
> + } catch (Exception e) {
> + e.printStackTrace();
Let's use an explicit log statement.
Attachment #8833878 -
Flags: review?(s.kaspari) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 8•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8833878 [details]
Bug 1329144 - CustomTabsActivity supports ActionButton
https://reviewboard.mozilla.org/r/109990/#review111554
> Let's use an explicit log statement.
OK! Log.w should be enough here.
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Target Milestone: --- → Firefox 54
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13520d439d2e
Remove useless variable r=sebastian
https://hg.mozilla.org/integration/autoland/rev/e474c788d36a
IntentUtil can extract ActionButton info from Intent r=sebastian
https://hg.mozilla.org/integration/autoland/rev/eac05c94053a
CustomTabsActivity supports ActionButton r=sebastian
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
|
||
Comment 11•8 years ago
|
||
Tested on Google+, News&Weather, Chromer and tapping on custom button display results.
Verified as fixed in build 55.0a1 (2017-05-17) with devices: HTC Desire 820 (Android 6.0.1) and Nexus 9 (Android 7.1.1).
Status: RESOLVED → VERIFIED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•